scope out virtualfile asyncification work #5158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he TBD EphemeralFile superclass instead
commit edbe3d2 Author: Arpad Müller <[email protected]> Date: Mon Aug 28 11:49:56 2023 +0200 Remove Read impl that was only used in one place commit 0d9fa95 Author: Arpad Müller <[email protected]> Date: Mon Aug 28 11:31:43 2023 +0200 Move used FileExt functions to inherent impls commit e983b3c Author: Arpad Müller <[email protected]> Date: Mon Aug 28 11:05:06 2023 +0200 Don't use generics bounded by trait commit a362ab9 Author: Arpad Müller <[email protected]> Date: Mon Aug 28 10:27:12 2023 +0200 Move VirtualFile::seek to inherent function commit 0cfc9ed Author: Arpad Müller <[email protected]> Date: Thu Aug 17 00:02:37 2023 +0200 Make read_blk and parts of the page cache async The returned PageReadGuard is not Send so we change the locks used for the SlotInner's in the page cache to the ones from tokio. Also, make read_blk async.
Insights: it's needed - for save_metadata and persistent_tenant_conf: these always "replace" the file to be overwritten with contents provided in an in-memory buffer. We can have a dedicated VirtualFile API for that purpose. - the Delta / Image layer writers need `Summary::ser_into(&summary, &mut file)?` and `write_all` . Probably feasible.
No tests were run or test report is not availableThe comment gets automatically updated with the latest test results
7f9897e at 2023-08-31T09:10:54.222Z :recycle: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR explores what's necessary to asyncify VirtualFile)
See #4743 (comment)