Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page cache metrics: remove unused read_accesses_ephemeral & read_hits_ephemeral #5338

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

problame
Copy link
Contributor

@problame problame commented Sep 19, 2023

We removed the user of this in #4994 .

But the metrics field was pub, so, didn't cause an unused-warning in #4994.

This is preliminary for: #5339

@problame problame requested review from a team as code owners September 19, 2023 16:38
@problame problame requested review from save-buffer, koivunej and jcsp and removed request for a team, save-buffer and koivunej September 19, 2023 16:38
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

2496 tests run: 2379 passed, 0 failed, 117 skipped (full report)


Flaky tests (2)

Postgres 16

  • test_remote_storage_backup_and_restore[True-local_fs]: debug

Postgres 14

  • test_crafted_wal_end[last_wal_record_xlog_switch_ends_on_page_boundary]: debug

Code coverage (full report)

  • functions: 53.0% (7787 of 14702 functions)
  • lines: 81.1% (45419 of 56007 lines)

The comment gets automatically updated with the latest test results
fa64e7e at 2023-09-20T16:05:54.495Z :recycle:

@problame problame enabled auto-merge (squash) September 20, 2023 15:28
@problame problame merged commit 93b41cb into main Sep 20, 2023
30 checks passed
@problame problame deleted the problame/page-cache-metrics/1-remove-ephemeral-file branch September 20, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants