Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layer): metric splitting, span rename #5902

Merged
merged 10 commits into from
Dec 7, 2023
Merged

Conversation

koivunej
Copy link
Member

@koivunej koivunej commented Nov 22, 2023

Per feedback, split the Layer metrics, also finally account for lost and re-submitted feedback on layer_gc by renaming it to layer_delete, Layer::garbage_collect_on_drop renamed to Layer::delete_on_drop. References to "gc" dropped from metric names and elsewhere.

Also fixes how the cancellations were tracked: there was one rare counter. Now there is a top level metric for cancelled inits, and the rare "download failed but failed to communicate" counter is kept.

Fixes: #6027

Copy link

github-actions bot commented Nov 22, 2023

2436 tests run: 2339 passed, 0 failed, 97 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_pageserver_restarts_under_worload: debug

Code coverage (full report)

  • functions: 54.7% (9339 of 17083 functions)
  • lines: 82.3% (54228 of 65897 lines)

The comment gets automatically updated with the latest test results
514291f at 2023-12-05T16:12:38.611Z :recycle:

@koivunej koivunej force-pushed the post_remove_remote_layer_ongoing branch 3 times, most recently from 512ba3e to 9d02ac4 Compare November 28, 2023 13:38
Base automatically changed from post_remove_remote_layer_ongoing to main November 28, 2023 17:15
@koivunej koivunej force-pushed the layer_metric_changes branch from 8834f5e to 1874795 Compare December 5, 2023 13:54
@koivunej koivunej marked this pull request as ready for review December 5, 2023 13:55
@koivunej koivunej requested a review from a team as a code owner December 5, 2023 13:55
@koivunej koivunej requested review from jcsp and removed request for a team December 5, 2023 13:55
so increase does not break.
@koivunej koivunej requested review from problame and removed request for jcsp December 5, 2023 13:58
they were previously tracked as well accidentially under rare counters,
under the failure case.
@koivunej koivunej changed the title refactor(layer): metric splitting, span rename fix(layer): metric splitting, span rename Dec 5, 2023
@koivunej
Copy link
Member Author

koivunej commented Dec 5, 2023

Failures on Postgres 15

  • test_metric_collection_cleans_up_tempfile: release

Interesting race, but I think it's rare enough. Here enabling the failpoint lead to an failpoint action (exit) before we had a chance to respond that we've configured the failpoints.

Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@koivunej koivunej merged commit 52718bb into main Dec 7, 2023
41 checks passed
@koivunej koivunej deleted the layer_metric_changes branch December 7, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

layer: metric name changes, track cancellations
3 participants