-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(layer): metric splitting, span rename #5902
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2436 tests run: 2339 passed, 0 failed, 97 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
514291f at 2023-12-05T16:12:38.611Z :recycle: |
koivunej
force-pushed
the
post_remove_remote_layer_ongoing
branch
3 times, most recently
from
November 28, 2023 13:38
512ba3e
to
9d02ac4
Compare
koivunej
force-pushed
the
layer_metric_changes
branch
from
December 5, 2023 13:54
8834f5e
to
1874795
Compare
so increase does not break.
they were previously tracked as well accidentially under rare counters, under the failure case.
koivunej
changed the title
refactor(layer): metric splitting, span rename
fix(layer): metric splitting, span rename
Dec 5, 2023
Interesting race, but I think it's rare enough. Here enabling the failpoint lead to an failpoint action (exit) before we had a chance to respond that we've configured the failpoints. |
jcsp
reviewed
Dec 5, 2023
jcsp
approved these changes
Dec 5, 2023
problame
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per feedback, split the Layer metrics, also finally account for lost and re-submitted feedback on
layer_gc
by renaming it tolayer_delete
,Layer::garbage_collect_on_drop
renamed toLayer::delete_on_drop
. References to "gc" dropped from metric names and elsewhere.Also fixes how the cancellations were tracked: there was one rare counter. Now there is a top level metric for cancelled inits, and the rare "download failed but failed to communicate" counter is kept.
Fixes: #6027