Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ImageCompressionAlgorithm::DisabledNoDecompress #8300

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Remove ImageCompressionAlgorithm::DisabledNoDecompress #8300

merged 3 commits into from
Jul 10, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Jul 6, 2024

Removes the ImageCompressionAlgorithm::DisabledNoDecompress variant. We now assume any blob with the specific bits set is actually a compressed blob.

The ImageCompressionAlgorithm::Disabled variant still remains and is the new default.

Reverts large parts of #8238 , as originally intended in that PR.

Part of #5431

@arpad-m arpad-m requested a review from a team as a code owner July 6, 2024 00:23
@arpad-m arpad-m requested a review from jcsp July 6, 2024 00:23
This was referenced Jul 6, 2024
Merged
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024 •
edited
Loading

3042 tests run: 2927 passed, 0 failed, 115 skipped (full report)

Flaky tests (2)

Postgres 15

  • test_isolation[None]: debug
  • test_pageserver_lsn_wait_error_safekeeper_stop: debug

Code coverage* (full report)

  • functions: 32.6% (6938 of 21278 functions)
  • lines: 50.0% (54528 of 109039 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
41e7909 at 2024-07-09T15:49:07.410Z :recycle:

@arpad-m arpad-m merged commit e78341e into main Jul 10, 2024
65 checks passed
@arpad-m arpad-m deleted the arpad/compression_7 branch July 10, 2024 16:09
arpad-m added a commit that referenced this pull request Jul 12, 2024
@arpad-m
Implement decompression for vectored reads (#8302)
2e37aa3 
Implement decompression of images for vectored reads.

This doesn't implement support for still treating blobs as uncompressed
with the bits we reserved for compression, as we have removed that
functionality in #8300 anyways.

Part of #5431
skyzh pushed a commit that referenced this pull request Jul 15, 2024
@arpad-m @skyzh
Remove ImageCompressionAlgorithm::DisabledNoDecompress (#8300)
8e2fe6b 
Removes the `ImageCompressionAlgorithm::DisabledNoDecompress` variant.
We now assume any blob with the specific bits set is actually a
compressed blob.

The `ImageCompressionAlgorithm::Disabled` variant still remains and is
the new default.

Reverts large parts of #8238 , as originally intended in that PR.

Part of #5431
skyzh pushed a commit that referenced this pull request Jul 15, 2024
@arpad-m @skyzh
Implement decompression for vectored reads (#8302)
0e600eb 
Implement decompression of images for vectored reads.

This doesn't implement support for still treating blobs as uncompressed
with the bits we reserved for compression, as we have removed that
functionality in #8300 anyways.

Part of #5431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

@jcsp jcsp Awaiting requested review from jcsp jcsp is a code owner automatically assigned from neondatabase/storage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arpad-m @skyzh