fix: dropping an op future at yield_now() after it completed causes panic #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
approved these changes
Jan 31, 2024
koivunej
reviewed
Jan 31, 2024
koivunej
reviewed
Jan 31, 2024
problame
force-pushed
the
problame/fix-iss-37/2
branch
2 times, most recently
from
3a71262 to
52b3484
Compare
|
Rebased & addressed review comments, including |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, dropping an operation future while it's in the
tokio::yield_nowwould cause a panic.This PR contains two commits: the first one reproduces the issue in a test.
The second one fixes the issue and repurposes the reproducer as a regression test.
Stacked atop #38
fixes #37