Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a Rdbms prototype repository for Porch #124

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Implement a Rdbms prototype repository for Porch #124

wants to merge 29 commits into from

Conversation

liamfallon
Copy link
Member

No description provided.

@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Oct 14, 2024
@liamfallon
Copy link
Member Author

/retest

@liamfallon
Copy link
Member Author

/retest

@nephio-prow nephio-prow bot added the approved label Oct 16, 2024
@liamfallon liamfallon changed the title Rdbms prototype Implement a Rdbms prototype repository for Porch Oct 23, 2024
@nagygergo
Copy link
Contributor

Could you add a makefile entry on setting up porch with a db repository

@liamfallon liamfallon force-pushed the rdbms-prototype branch 3 times, most recently from e152270 to 89a27f9 Compare November 4, 2024 16:39
@liamfallon
Copy link
Member Author

/retest

@liamfallon
Update fox for resource deletion
7bf84e9
@liamfallon
Remove namespace from package names
ea39079
@liamfallon
Return pointer rather than instance on read of PackageRevision from db
4447fd6
@liamfallon
Fix up comments after rebase
8d2b109
@liamfallon
Fix up comments after rebase
2c27028
@liamfallon
Update db repo due to rebases
3ee36c7
@liamfallon
Rebased against main
42683cf
@liamfallon
Added config for db tutorial
33a2595
@liamfallon
Added package resource perisistence
45cee4b
@liamfallon
porchctl pull/push supported
3e97dcd
@liamfallon
Fix push deleting resources on package on no change push
b139454
@liamfallon
Propose delete now working
b0b0aeb
@liamfallon
Add namespace to db creation Yaml file
f626eb7
@liamfallon
Remove namespace from package names
430c104
@liamfallon
Return pointer rather than instance on read of PackageRevision from db
617eafc
@liamfallon
Fix up comments after rebase
5fee978
@liamfallon
Fix up comments after rebase
077c701
@liamfallon
Update db repo due to rebases
885fa7e
@liamfallon
Use a RDBMS as a cache in Porch
99ff36e
@liamfallon
Rebase against main
bcb1c22
@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Nov 28, 2024

@liamfallon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
presubmit-nephio-go-test 4cfd557 link true /test presubmit-nephio-go-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiacor efiacor Awaiting requested review from efiacor

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees
No one assigned
Labels
approved do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamfallon @nagygergo