From c7c7ad25027327d93a829ff7b939fc667ead6812 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ruilong=20Li=28=E6=9D=8E=E7=91=9E=E9=BE=99=29?= Date: Fri, 13 Oct 2023 12:49:00 -0700 Subject: [PATCH] float3 fix (#44) Co-authored-by: Ruilong Li <397653553@qq.com> --- .github/workflows/building.yml | 14 +++++++++----- gsplat/cuda/csrc/forward.cu | 3 +-- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/.github/workflows/building.yml b/.github/workflows/building.yml index 58ee3059f..68e59da2f 100644 --- a/.github/workflows/building.yml +++ b/.github/workflows/building.yml @@ -11,11 +11,15 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-20.04, windows-2019] - # support version based on: https://download.pytorch.org/whl/torch/ - python-version: ['3.7', '3.8', '3.9', '3.10', '3.11'] - torch-version: [1.11.0, 1.12.0, 1.13.0, 2.0.0] - cuda-version: ['cu113', 'cu115', 'cu116', 'cu117', 'cu118'] + os: [windows-2019] + python-version: ['3.7'] + torch-version: [1.11.0] + cuda-version: ['cu113'] + # os: [ubuntu-20.04, windows-2019] + # # support version based on: https://download.pytorch.org/whl/torch/ + # python-version: ['3.7', '3.8', '3.9', '3.10', '3.11'] + # torch-version: [1.11.0, 1.12.0, 1.13.0, 2.0.0] + # cuda-version: ['cu113', 'cu115', 'cu116', 'cu117', 'cu118'] exclude: - torch-version: 1.11.0 python-version: '3.11' diff --git a/gsplat/cuda/csrc/forward.cu b/gsplat/cuda/csrc/forward.cu index 5f29a3525..c737bd54a 100644 --- a/gsplat/cuda/csrc/forward.cu +++ b/gsplat/cuda/csrc/forward.cu @@ -662,8 +662,7 @@ __device__ float3 project_cov3d_ewa( glm::mat3 cov = T * V * glm::transpose(T); // add a little blur along axes and save upper triangular elements - return (float3 - ){float(cov[0][0]) + 0.3f, float(cov[0][1]), float(cov[1][1]) + 0.3f}; + return float3(float(cov[0][0]) + 0.3f, float(cov[0][1]), float(cov[1][1]) + 0.3f); } // device helper to get 3D covariance from scale and quat parameters