From 502d3ed2bf9a13bf4be8d1265a01b27fbff57cc8 Mon Sep 17 00:00:00 2001 From: Ruilong Li <397653553@qq.com> Date: Fri, 27 Sep 2024 03:52:58 +0000 Subject: [PATCH 1/2] fix workflow --- .github/workflows/publish.yml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 941866cc..9dd3167d 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -7,6 +7,9 @@ on: release: types: [created] +permissions: + contents: write + jobs: # Build the wheels using reusable_building.yml @@ -68,6 +71,8 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} publish_dir: ./whl # Directory where the simple index pages are located destination_dir: whl # The 'wh' folder in the GitHub Pages root + keep_files: false # This will only erase the destination subdirectory. + cname: docs.gsplat.studio upload_pypi: name: Upload to PyPi @@ -80,6 +85,11 @@ jobs: name: pypi_packages path: dist + - name: Install dependencies + run: | + python -m pip install build twine + shell: bash + # - name: Publish package to Test PyPI # uses: pypa/gh-action-pypi-publish@release/v1 # with: @@ -90,4 +100,5 @@ jobs: env: PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }} run: | - twine upload --username __token__ --password $PYPI_TOKEN dist/* \ No newline at end of file + twine upload --username __token__ --password $PYPI_TOKEN dist/* + shell: bash \ No newline at end of file From af3f9e1420f2a8518aed2c8c0ad6e3c4dc8289b5 Mon Sep 17 00:00:00 2001 From: Ruilong Li <397653553@qq.com> Date: Fri, 27 Sep 2024 03:55:45 +0000 Subject: [PATCH 2/2] fix --- gsplat/rendering.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gsplat/rendering.py b/gsplat/rendering.py index 9457ca73..83ec6e77 100644 --- a/gsplat/rendering.py +++ b/gsplat/rendering.py @@ -177,8 +177,8 @@ def rasterization( distributed: Whether to use distributed rendering. Default is False. If True, The input Gaussians are expected to be a subset of scene in each rank, and the function will collaboratively render the images for all ranks. - ortho: Whether to use orthographic projection. In such case fx and fy become the scaling - factors to convert projected coordinates into pixel space and cx, cy become offsets. + camera_model: The camera model to use. Supported models are "pinhole", "ortho", + and "fisheye". Default is "pinhole". covars: Optional covariance matrices of the Gaussians. If provided, the `quats` and `scales` will be ignored. [N, 3, 3], Default is None.