Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Coordinate system #42

Closed
amclain opened this issue Jun 28, 2020 · 0 comments · Fixed by #54
Closed

Refactor: Coordinate system #42

amclain opened this issue Jun 28, 2020 · 0 comments · Fixed by #54
Assignees
Labels
refactor Refactoring code or tech debt repayment

Comments

@amclain
Copy link
Member

amclain commented Jun 28, 2020

Depends on #43.

As mentioned in the 2020-06-23 meeting, the Keybow's physical pixels are rendered based on a position-dependent list, @pixels, in utils.ex. In this list the elements have to be in the same order that the pixels are arranged on the Keybow on the SPI bus. We would like hardware layer that controls the pixels (RGBMatrix) to be responsible for translating the pixels in a Frame to the correct physical representation.

TBD: The strategy we choose to refactor this will most likely be dependent on how we decide to design pixel layouts in #43.

@amclain amclain added feature A new feature or enhancement to an existing feature refactor Refactoring code or tech debt repayment and removed feature A new feature or enhancement to an existing feature labels Jun 28, 2020
@doughsay doughsay mentioned this issue Jul 5, 2020
4 tasks
@doughsay doughsay self-assigned this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring code or tech debt repayment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants