Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor casting in Animation.Config module #84

Closed
2 tasks
vanvoljg opened this issue Jul 15, 2020 · 2 comments
Closed
2 tasks

Refactor casting in Animation.Config module #84

vanvoljg opened this issue Jul 15, 2020 · 2 comments
Labels
duplicate This issue or pull request already exists refactor Refactoring code or tech debt repayment

Comments

@vanvoljg
Copy link
Member

There are a couple TODO notes for refactoring the casting logic in RGBMatrix.Animation.Config. @amclain, I think you had a suggestion for how we could do this, didn't you?

@vanvoljg vanvoljg added the refactor Refactoring code or tech debt repayment label Jul 15, 2020
@amclain
Copy link
Member

amclain commented Jul 16, 2020

This is a duplicate of #70. I recommend we close this issue and move the checkboxes to the other one.

@amclain, I think you had a suggestion for how we could do this, didn't you?

I made a comment to log the tech debt in the PR: #56 (comment)

I also jotted down some pseudo-code for cast, which I believe was implemented: #54 (comment)

@amclain amclain added the duplicate This issue or pull request already exists label Jul 16, 2020
@vanvoljg
Copy link
Member Author

I thought it was somewhere, but missed it in the list. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists refactor Refactoring code or tech debt repayment
Projects
None yet
Development

No branches or pull requests

2 participants