Add account locks to getAccountWithAuthorizationClaims method #1847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
There was a race condition within the
getAccountWithAuthorizationClaims
method which was causing some operations to not store the updated data properly in the backend because it was overwriting with an old state. This PR adds account locks to this method to avoid overwriting.How I reproduced:
updateAccountDomainAttributes
right before theSaveAccount
(line 1420) or within theSaveAccount
method itself likeFor the majority of attempts, this will not work and the key is not persistent in the database even though the API returns with success.
Issue ticket number and link
netbirdio/dashboard#371
Checklist