[client] Don't choke on non-existent interface in route updates #2922
Conversation
lixmal
force-pushed
the
win-interface
branch
from
5d89af5
to
01a7c71
Compare
lixmal
changed the title
|
| @@ -230,10 +230,13 @@ func (rm *RouteMonitor) parseUpdate(row *MIB_IPFORWARD_ROW2, notificationType MI | |||
| if idx != 0 { | |||
| intf, err := net.InterfaceByIndex(idx) | |||
| if err != nil { | |||
| return update, fmt.Errorf("get interface name: %w", err) | |||
There was a problem hiding this comment.
Based on the description of the PR, it was to help debug things only. But if you remove the return the logic will be different. Or not?
There was a problem hiding this comment.
The logic is slightly different, we won't error out here, instead, we will return the interface info we have (index). Index is sufficient for the current checks we have in the network monitor for Windows.
This case where we cannot lookup the interface only happens if we get a route update notification from the OS at the same time as the interface is removed (e.g. the interface is removed and all routes that point to it are removed as well, like in the linked issue).
Describe your changes
Improves debugging in cases like #2742
Issue ticket number and link
Checklist