User-AS: support bind IP for user attachment point #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcfrei
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Add collapsible form field for bind_ip in the user AS attachment point form. The model field backing this has already been there (host.bind_ip). Also, consider this optional bind_ip in the creation of the OpenVPN server config.
matzf
force-pushed
the
matzf/user-ap-bind-ip
branch
from
0fdf996 to
8ea8860
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add collapsible form field for bind_ip in the user AS attachment point form. The model field backing this has already been there (host.bind_ip).
Also, consider this optional bind_ip in the creation of the OpenVPN server config.
Fixes #442
This change is