Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"transformed_result" property of AbstractResultExtractor has several types #45

Open
lucmurer opened this issue Nov 17, 2021 · 0 comments

Comments

@lucmurer
Copy link
Contributor

The "transformed_result" property of AbstractResultExtractor has inconsistent types depending on the subclass:

  • In "AbstractHostResultExtractor" it is Dict[str, NutsResult]
  • In "AbstractHostDestResultExtractor" it is Dict[str, Dict[str, NutsResult]]

To me this is an issue due to the following reasons:

  1. The transformed result is a public interface property of the class, at least intended to be used in the per-test created "Extractor" subclass. This could pose a source of confusion
  2. Static type checking is undermined or at least made difficult with these two options.

Possible Solutions to this:

@lucmurer lucmurer added this to the Release 4.0.0 milestone Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant