-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more information when returning 403 #833
Conversation
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
==========================================
+ Coverage 94.36% 94.38% +0.01%
==========================================
Files 30 30
Lines 3921 3933 +12
Branches 434 436 +2
==========================================
+ Hits 3700 3712 +12
Misses 166 166
Partials 55 55
|
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
==========================================
+ Coverage 94.36% 94.37% +0.01%
==========================================
Files 30 30
Lines 3921 3929 +8
Branches 434 436 +2
==========================================
+ Hits 3700 3708 +8
Misses 166 166
Partials 55 55
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we want to completely stop using aiohttp_security.check_permission
. have we checked our options re extending our auth policies etc?
@asvetlov is it reasonable to extend |
created an issue on aiohttp_security: aio-libs/aiohttp-security#241 |
In any case, if we decide to fix this in
Personally, I'd stick to the first option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayushkovskiy please create an issue for moving these changes to neuro-auth-client
.
Motivation: when one executes
neuro run/log/top/delete
with multiple resources used (image, volumes), we raise justweb.HTTPForbidden
without any additional information on which exactly resource is forbidden.In future, we will need to patch all errors we raise server-side to provide more information there (i.e.
raise web.HTTPForbidden()
does not include any body, so we should get rid of it).