-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC fix typos & FIX modify python version for website builder #547
base: staging
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated test error: #548
@PSSF23 what did you do about the MLKNN unit test? |
Nothing. Unrelated. |
The unit tests seem to fail. |
Yes. But it's not related to this PR. I made another issue #548 for that. |
It's bad practice to merge PRs without all checks being passed! It will be better to possibly take out that unit test or use @pargma no cover to ignore the unit test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdey4 ignored the test for now.
Codecov ReportBase: 92.36% // Head: 88.54% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## staging #547 +/- ##
===========================================
- Coverage 92.36% 88.54% -3.82%
===========================================
Files 7 7
Lines 419 419
===========================================
- Hits 387 371 -16
- Misses 32 48 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Reference issue
Close #546
Close #543
Type of change
Documentation, Website
What does this implement/fix?
Additional information