Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Even faster unsupervised forests and trees #117

Merged
merged 6 commits into from
Aug 24, 2023
Merged

[ENH] Even faster unsupervised forests and trees #117

merged 6 commits into from
Aug 24, 2023

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Aug 23, 2023

Fixes #13

Changes proposed in this pull request:

  • Removes the extra for loops in update that have to recompute the statistics.

  • All statistics are computed and stored in a hash map during init_feature_vec

  • Re-assign and compute statistics w/o a for-loop during update.

  • Just inlines functions

  • updates wrt scikit-learn main

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fc48cef) 86.73% compared to head (ba2a3bf) 86.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   86.73%   86.73%           
=======================================
  Files          26       26           
  Lines        2111     2111           
=======================================
  Hits         1831     1831           
  Misses        280      280           
Files Changed Coverage Δ
sktree/tests/test_honest_forest.py 100.00% <ø> (ø)
sktree/tree/_classes.py 75.00% <100.00%> (ø)
sktree/tree/tests/test_unsupervised_tree.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
@adam2392 adam2392 merged commit 9a325ae into main Aug 24, 2023
24 of 25 checks passed
@adam2392 adam2392 deleted the fasterbic branch August 24, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement FasterBIC
1 participant