Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIXME: join the RETURNING * with the original values to construct the actual historical value #57

Open
s4ke opened this issue Sep 26, 2023 · 1 comment
Open

FIXME: join the RETURNING * with the original values to construct the actual historical value #57

s4ke opened this issue Sep 26, 2023 · 1 comment

Comments

@s4ke
Copy link
Member

s4ke commented Sep 26, 2023

see comment here https://github.com/neuroforgede/nfcompose/blob/8ecd994ae3e5ae5f149cd8a4ef1a4219483d7125/skipper/skipper/dataseries/storage/dynamic_sql/queries/modification_materialized/insert.py#L313C10-L313C10
@s4ke s4ke changed the title When doing an upsert in the flat historical backend we should always return the updated state FIXME: join the RETURNING * with the original values to construct the actual historical value Sep 26, 2023
@s4ke
Copy link
Member Author

s4ke commented Sep 26, 2023

The question is more - is this even still relevant. Logic seems to be there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s4ke