Better document UserDict and remove unnecessary references to self.data.
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeZiminski
changed the title
UserDict and remove uncessary references to self.data.UserDict and remove unnecessary references to self.data.
JoeZiminski
force-pushed
the
remove_references_to_self_data_in_userdict
branch
from
a9a4c8c
to
ea3414d
Compare
Merged
lauraporta
approved these changes
Nov 16, 2023
JoeZiminski
force-pushed
the
remove_references_to_self_data_in_userdict
branch
from
ea3414d
to
84c93a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
UserDictis a little obscure, and it is not clear that the dictionary for theUserDictobject is held inself.data. Here, only useself.dataif necessary, otherwise access dictionary items withself[key]. Further, add better documentation on theUserDict.