Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tests so that they are faster. #160

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Conversation

JoeZiminski
Copy link
Member

@JoeZiminski JoeZiminski commented Dec 12, 2023

This PR performs a major refactor of tests to use spikeinterface toy example and mountainsort. These means tests:

  1. run much faster than previously
  2. run on mountainsort so do not require GPU

Running tests on a small real-life spikeglx recording in all sorters is still available. This will be run on our internal tests.

Tests are also now added to CI.

@JoeZiminski JoeZiminski force-pushed the major_test_speedups branch 3 times, most recently from 48163fb to 043029a Compare December 14, 2023 19:22
JoeZiminski and others added 4 commits December 14, 2023 20:05
try neuroinformatics tests.

try checkout v4

Fix  instead of .

Pin to spikeinterface fork.

force tests

force tests

Install from my fork for now.

remove not implemnted test and skip singularity tests.

troubleshooting.

continue troubleshooting.

troubleshooting.

omd finally fix?

remove macos exception.

mountainsort5 all OS + iterate all os python comb.

wait for delete folder on windows.

Add more tailred os and python version combination.

Continue to make windows deletion safe on CI.

more trouble.

trying something

Finish.

keep trying windows delete issue

Workaround for file still open error on windows.
@JoeZiminski JoeZiminski merged commit 7b263fe into dev Dec 14, 2023
14 checks passed
@JoeZiminski JoeZiminski deleted the major_test_speedups branch December 14, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant