Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public arg validation #98

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Public arg validation #98

merged 2 commits into from
Aug 30, 2023

Conversation

JoeZiminski
Copy link
Member

@JoeZiminski JoeZiminski commented Aug 30, 2023

Add initial validation for all public function arguments. There are better ways to do this, and key improvements in a soon-to-come issue will be:

  1. move up as many low-level assert checks into exceptions that raise as soon as the fucntions are run. This will help avoid mid-pipeline crashes and also clean up the code
  2. Use a proper validator package similar to Niko's work on movement.

@JoeZiminski JoeZiminski merged commit 9f7a068 into dev Aug 30, 2023
1 check passed
@JoeZiminski JoeZiminski deleted the public_arg_validation branch August 30, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant