Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download_utils: Function definition missing for downloading from Google drive #260

Open
bauerfe opened this issue Aug 2, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@bauerfe
Copy link
Collaborator

bauerfe commented Aug 2, 2023

The function download_url in the download_utils module attempts to call a function download_file_from_google_drive, which is not defined, see here.

@bauerfe bauerfe added the bug Something isn't working label Aug 2, 2023
@biphasic
Copy link
Member

biphasic commented Aug 2, 2023

thanks for reporting this. Should we bring it back? Not sure it still works though

https://github.com/neuromorphs/tonic/blob/35f6118850abf7e63b32667f519f0b6f65e68450/tonic/download_utils.py#L120C1-L170C1

@fabrizio-ottati
Copy link
Collaborator

Usually with the drive stuff it is better if the user does it manually like with Prophesee stuff?

@bauerfe
Copy link
Collaborator Author

bauerfe commented Aug 3, 2023

Yeah I see your pont. I just tried the function from torchvision and at least for the dataset I'm looking at it fails without any warning.

Then maybe it's better instead to produce an error message, saying that data from google drives should be downloaded manually?

@biphasic
Copy link
Member

biphasic commented Aug 3, 2023

yes agreed!

@fabrizio-ottati
Copy link
Collaborator

There is also a function from torchdata, but since its development is paused, it is better to provide an error message. What do you think?

@biphasic
Copy link
Member

biphasic commented Aug 3, 2023

I think that makes total sense. Let the user download it manually for now

@biphasic
Copy link
Member

biphasic commented Sep 8, 2023

Just tried out https://github.com/wkentaro/gdown/tree/main and it works super well. Should switch to that for Gdrive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants