Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update __init__.py to catch attempts to plot species instead of speci… #2468

Merged
merged 13 commits into from
Oct 20, 2023
Merged

Update __init__.py to catch attempts to plot species instead of speci… #2468

merged 13 commits into from
Oct 20, 2023

Conversation

sgamiye
Copy link
Collaborator

@sgamiye sgamiye commented Aug 21, 2023 •
edited by rgourdine
Loading

…es on region

closes #1060

@azure-pipelines
Copy link

✔️ 3fc4ad4 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@codecov
Copy link

codecov bot commented Aug 21, 2023 •
edited
Loading

Codecov Report

Merging #2468 (3fc4ad4) into master (1291126) will decrease coverage by 5.43%.
The diff coverage is 0.00%.

❗ Current head 3fc4ad4 differs from pull request most recent head 38169da. Consider uploading reports for the commit 38169da to get more accurate results

@@            Coverage Diff             @@
##           master    #2468      +/-   ##
==========================================
- Coverage   65.83%   60.41%   -5.43%     
==========================================
  Files         559      626      +67     
  Lines      108902   120817   +11915     
==========================================
+ Hits        71698    72990    +1292     
- Misses      37204    47827   +10623
Files Coverage Δ
share/lib/python/neuron/__init__.py 39.81% <0.00%> (-0.28%) ⬇️

... and 195 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@azure-pipelines
Copy link

✔️ 1c8ead1 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@adamjhn
Copy link
Member

adamjhn commented Sep 25, 2023

It looks like this is failing because plotly isn't install in the CI. Should we add it?

@azure-pipelines
Copy link

✔️ dc41863 -> Azure artifacts URL

@ramcdougal
Copy link
Member

Going to need the same fix for _do_plot which has the same issue. Will also need to install ipywidgets...

@azure-pipelines
Copy link

✔️ 32bfe93 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines
Copy link

✔️ 1db125d -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines
Copy link

✔️ b71ecb4 -> Azure artifacts URL

@azure-pipelines
Copy link

✔️ 38169da -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
ramcdougal
ramcdougal requested changes Oct 19, 2023
View reviewed changes
test/rxd/test_pltvar.py Outdated Show resolved Hide resolved
test/rxd/test_pltvar.py Outdated Show resolved Hide resolved
test/rxd/test_pltvar.py Outdated Show resolved Hide resolved
test/rxd/test_pltvar.py Outdated Show resolved Hide resolved
test/rxd/test_pltvar.py Show resolved Hide resolved
@azure-pipelines
Copy link

✔️ 95c9af4 -> Azure artifacts URL

@ramcdougal ramcdougal enabled auto-merge (squash) October 20, 2023 19:56
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@azure-pipelines
Copy link

✔️ 0e83c98 -> Azure artifacts URL

@ramcdougal ramcdougal merged commit 728ae2f into master Oct 20, 2023
32 of 34 checks passed
@ramcdougal ramcdougal deleted the plot_species_fix branch October 20, 2023 22:36
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #163887 (:no_entry:) have been uploaded here!

Status and direct links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramcdougal ramcdougal ramcdougal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

catch attempts to plot species instead of species on region
5 participants
@sgamiye @bbpbuildbot @adamjhn @ramcdougal @rgourdine