Introduce unique_cstr.
#3245
Merged
Introduce unique_cstr.
#3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ 5b6bf9d -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3245 +/- ##
=======================================
Coverage 67.09% 67.09%
=======================================
Files 570 571 +1
Lines 111082 111089 +7
=======================================
+ Hits 74525 74532 +7
Misses 36557 36557 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
alkino
approved these changes
Nov 25, 2024
|
The difficulty is this line here: nrn/src/nrnpython/nrnpy_hoc.cpp Lines 739 to 741 in 5b6bf9d it leaks all strings stored in |
This comment has been minimized.
This comment has been minimized.
matz-e
approved these changes
Nov 26, 2024
This commit adds a RAII wrapper for C-strings, called `unique_cstr`. Several places in the NRN Python bindings use `char *` when owning a malloc allocated string. This new class is then used to prevent leaking HOC strings on error paths.
|
|
✔️ 9ed485b -> Azure artifacts URL |
alkino
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a RAII wrapper for C-strings, called
unique_cstr. Several places in the NRN Python bindings usechar *when owning a malloc allocated string.This new class is then used to prevent leaking HOC strings on error paths, see #1437