Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create DatasetSearcher class for transforming Datasets #669

Open
tsalo opened this issue Apr 22, 2022 · 1 comment · May be fixed by #677
Open

Create DatasetSearcher class for transforming Datasets #669

tsalo opened this issue Apr 22, 2022 · 1 comment · May be fixed by #677
Labels
breaking-change PRs that change results or interfaces. enhancement New feature or request

Comments

@tsalo
Copy link
Member

tsalo commented Apr 22, 2022

Summary

Per today's discussion, one thing that would make it easier to simplify the Dataset object would be to move the Dataset's searching methods into a new Transformer-like class.

Additional details

It would make it easier to convert Dataset into a more NIMADS-like structure.
@tsalo tsalo added enhancement New feature or request breaking-change PRs that change results or interfaces. labels Apr 22, 2022
@tsalo
Copy link
Member Author

tsalo commented Apr 28, 2022

I've started on this, but I immediately ran into a bunch of circular imports. I'm hoping that #674 and #675 will make identifying and fixing circular imports easier.

@tsalo tsalo linked a pull request Apr 28, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change PRs that change results or interfaces. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add DatasetSearcher class with search methods from Dataset tsalo/NiMARE
1 participant
@tsalo