From 79fd29c1e894d9a2438395bc1a6a609c2ef86f8f Mon Sep 17 00:00:00 2001 From: lukema95 <867273263@qq.com> Date: Sun, 31 Dec 2023 14:09:34 +0800 Subject: [PATCH] remove ValidateBasic in cli --- x/dex/client/cli/tx_cancel_limit_order.go | 3 --- x/dex/client/cli/tx_deposit.go | 3 --- x/dex/client/cli/tx_multi_hop_swap.go | 3 --- x/dex/client/cli/tx_place_limit_order.go | 3 --- x/dex/client/cli/tx_withdrawl.go | 3 --- x/dex/client/cli/tx_withdrawl_filled_limit_order.go | 3 --- x/interchainqueries/client/cli/tx.go | 7 ------- 7 files changed, 25 deletions(-) diff --git a/x/dex/client/cli/tx_cancel_limit_order.go b/x/dex/client/cli/tx_cancel_limit_order.go index be88aec63..ea5916880 100644 --- a/x/dex/client/cli/tx_cancel_limit_order.go +++ b/x/dex/client/cli/tx_cancel_limit_order.go @@ -25,9 +25,6 @@ func CmdCancelLimitOrder() *cobra.Command { clientCtx.GetFromAddress().String(), args[0], ) - if err := msg.ValidateBasic(); err != nil { - return err - } return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg) }, diff --git a/x/dex/client/cli/tx_deposit.go b/x/dex/client/cli/tx_deposit.go index 5ae248316..5495d5761 100644 --- a/x/dex/client/cli/tx_deposit.go +++ b/x/dex/client/cli/tx_deposit.go @@ -108,9 +108,6 @@ func CmdDeposit() *cobra.Command { FeesUint, DepositOptions, ) - if err := msg.ValidateBasic(); err != nil { - return err - } return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg) }, diff --git a/x/dex/client/cli/tx_multi_hop_swap.go b/x/dex/client/cli/tx_multi_hop_swap.go index cfa76006c..3b70e54bc 100644 --- a/x/dex/client/cli/tx_multi_hop_swap.go +++ b/x/dex/client/cli/tx_multi_hop_swap.go @@ -62,9 +62,6 @@ func CmdMultiHopSwap() *cobra.Command { exitLimitPriceDec, pickBest, ) - if err := msg.ValidateBasic(); err != nil { - return err - } return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg) }, diff --git a/x/dex/client/cli/tx_place_limit_order.go b/x/dex/client/cli/tx_place_limit_order.go index 7c3d05154..c679aeb29 100644 --- a/x/dex/client/cli/tx_place_limit_order.go +++ b/x/dex/client/cli/tx_place_limit_order.go @@ -93,9 +93,6 @@ func CmdPlaceLimitOrder() *cobra.Command { goodTil, maxAmountOutIntP, ) - if err := msg.ValidateBasic(); err != nil { - return err - } return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg) }, diff --git a/x/dex/client/cli/tx_withdrawl.go b/x/dex/client/cli/tx_withdrawl.go index 07803c114..3ce91a209 100644 --- a/x/dex/client/cli/tx_withdrawl.go +++ b/x/dex/client/cli/tx_withdrawl.go @@ -78,9 +78,6 @@ func CmdWithdrawal() *cobra.Command { TicksIndexesInt, FeesUint, ) - if err := msg.ValidateBasic(); err != nil { - return err - } return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg) }, diff --git a/x/dex/client/cli/tx_withdrawl_filled_limit_order.go b/x/dex/client/cli/tx_withdrawl_filled_limit_order.go index 6829d72e0..d900d4b6b 100644 --- a/x/dex/client/cli/tx_withdrawl_filled_limit_order.go +++ b/x/dex/client/cli/tx_withdrawl_filled_limit_order.go @@ -25,9 +25,6 @@ func CmdWithdrawFilledLimitOrder() *cobra.Command { clientCtx.GetFromAddress().String(), args[0], ) - if err := msg.ValidateBasic(); err != nil { - return err - } return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg) }, diff --git a/x/interchainqueries/client/cli/tx.go b/x/interchainqueries/client/cli/tx.go index 798a35f8d..e86cb8e67 100644 --- a/x/interchainqueries/client/cli/tx.go +++ b/x/interchainqueries/client/cli/tx.go @@ -49,9 +49,6 @@ func RemoveInterchainQueryCmd() *cobra.Command { } msg := types.NewMsgRemoveInterchainQuery(sender, queryID) - if err = msg.ValidateBasic(); err != nil { - return err - } return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), &msg) }, @@ -92,10 +89,6 @@ func SubmitQueryResultCmd() *cobra.Command { return fmt.Errorf("failed to unmarshal query result: %w", err) } - if err = msg.ValidateBasic(); err != nil { - return err - } - return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), &msg) }, }