Nev fixes after steep review #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevinera
force-pushed
the
nev--fixes-after-steep-review
branch
from
8d8c9f8
to
4c8dc87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a review on #28 after it merged that had some good points, and I wanted to go ahead and get them taken care of.
:testconfig in the Steepfile would be for a 'test/' directory, which we don't have. In general, RBS doesn't do much for rspec tests, since they are constructed as massive piles of anonymous metaprogrammed modules and classes (which don't have any type information).?Foosyntax to specify the optional parameter tofetch, instead of listing multiple signatures (it's equivalent, but the former is clearer and better)(I also tried to use groups to manage the installation of the steep gem instead of an environment variable but.. failed. See here for details)