Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nev fixes after steep review #32

Merged
merged 3 commits into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .bundle/config
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
BUNDLE_WITHOUT: "typing"
12 changes: 1 addition & 11 deletions .github/workflows/rspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}

- name: Cache gems
uses: actions/cache@v3
with:
path: vendor/bundle
key: ${{ runner.os }}-rspec-${{ matrix.ruby-version }}-${{ hashFiles('Gemfile.lock') }}
restore-keys:
${{ runner.os }}-rspec-${{ matrix.ruby-version }}-

- name: Install gems
run: bundle install --jobs 4 --retry 3
bundler-cache: true

- name: Run RSpec
run: bundle exec rspec
8 changes: 0 additions & 8 deletions Steepfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,3 @@ target :lib do
library "pathname"
library "date"
end

target :test do
signature "sig"
check "test"
configure_code_diagnostics(D::Ruby.default)
library "pathname"
library "date"
end
3 changes: 1 addition & 2 deletions sig/environment_helpers.rbs
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ module EnvironmentHelpers

module AccessHelpers
# (Actually provided by ENV, which these are all extended onto)
def fetch: (String name) -> String?
| (String name, String? default) -> String?
def fetch: (String name, ?String? default) -> String?

private def fetch_value: (String name, required: bool) -> String?
private def check_default_type: (String | Symbol context, untyped value, *Class types) -> void
Expand Down