Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General changes #3

Open
AbhiAgarwal opened this issue Nov 1, 2017 · 9 comments
Open

General changes #3

AbhiAgarwal opened this issue Nov 1, 2017 · 9 comments

Comments

@AbhiAgarwal
Copy link
Member

AbhiAgarwal commented Nov 1, 2017

API structure is similar, but a lot of internals have changed.

  1. There needs to be / after each URL now. Django enforces this (can't get around it).

Basically: used to be /users/me. Now it has to be /users/me/. It will redirect you, which will cause an extra 301 - so change all to /users/me/

Even when you do /contacts/1/ (not /contacts/1)

  1. Endpoint https://api.newsai.org/

  2. For now, disable public lists & billing. No real need for them rn.

@AbhiAgarwal
Copy link
Member Author

There's generally docs here: https://api.newsai.org/docs/

That should catalog all the endpoints. Probably not worth using this to do POST/GET requests, but just to see what endpoints exist

@AbhiAgarwal
Copy link
Member Author

AbhiAgarwal commented Nov 8, 2017

  • Also remove "Invite" from settings (temp)
  • Remove Daily Digest Subscription

@AbhiAgarwal
Copy link
Member Author

AbhiAgarwal commented Nov 8, 2017

auth changes:

google login (on homepage)

https://api.newsai.org/api/auth/login/google-oauth2/

gmail auth (in settings)

https://api.newsai.org/api/auth/login/gmail-oauth2/

outlook auth (in settings)

https://api.newsai.org/api/auth/login/outlook-oauth2/

smtp auth (in settings)

https://api.newsai.org/api/auth/login/nylas-oauth/

we're removing the email-settings nonsense. Nylas will handle smtp (and any other email provider). You can change SMTP to just "Other". It'll cover all cases - which aren't gmail or outlook

only enable "Sign-in with Google" for now. Comment out Register/Login

@AbhiAgarwal
Copy link
Member Author

AbhiAgarwal commented Nov 8, 2017

The time changes to a UNIX timestamp (the JSON renderer uses timestamp & can't change)

@AbhiAgarwal
Copy link
Member Author

there's a v1: https://api.newsai.org/api/v1/lists/

@AbhiAgarwal
Copy link
Member Author

AbhiAgarwal commented Nov 9, 2017

There's no v1 in auth: https://api.newsai.org/api/auth/login/nylas-oauth/ (or any of the auth things)

@juliepanda
Copy link

juliepanda commented Nov 9, 2017

Login:

  • make only Google login for now

Email Settings:

  • Gmail auth / remove
  • Outlook auth / remove
  • SMTP auth / remove
  • check if all the email auth conditionals still work
  • check if they all work w/ site redirects when site is live

Other:

  • rm Invite
  • rm Daily Digest Sub
  • disable Public Lists
  • disable Billing

Lists:

  • Change how /lists ordering is queried

Cleanups + Bugs:

  • flattenChildren bug when lists queried is implement when using +alphabetical and -alphabetical in ListManager

@AbhiAgarwal
Copy link
Member Author

AbhiAgarwal commented Nov 10, 2017

@juliepanda

also queries change to something like

https://api.newsai.org/api/v1/lists/?order=-updated

order will be -updated, -created rather than -Created, -Updated

& having a slash at the end won't work -updated/ will not work

@juliepanda
Copy link

/users/<id>/remove-integrations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants