Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists endpoint (Added endpoint) #7

Open
AbhiAgarwal opened this issue Nov 3, 2017 · 7 comments
Open

Lists endpoint (Added endpoint) #7

AbhiAgarwal opened this issue Nov 3, 2017 · 7 comments

Comments

@AbhiAgarwal
Copy link
Member

Not really much change

/lists/<id>/add-tags/

/lists/<id>/remove-tags/

just POST with tags array

@AbhiAgarwal
Copy link
Member Author

AbhiAgarwal commented Nov 3, 2017

There's an archive endpoint now /lists/<id>/archive/ GET

So no need to POST. It'll automatically adjust

@AbhiAgarwal
Copy link
Member Author

AbhiAgarwal commented Nov 3, 2017

Also added an endpoint

/lists/<id>/add-custom-field/

When they click "Add Column" or whatever.

{
"name": "",
"value": "",
"customfield": True,
"hidden": False
}

Just to structure each portion properly

You don't have to use it just yet. PATCH/POST will still work. just an extra endpoint

@AbhiAgarwal AbhiAgarwal changed the title Lists endpoint Lists endpoint (Only additions) Nov 8, 2017
@AbhiAgarwal AbhiAgarwal changed the title Lists endpoint (Only additions) Lists endpoint (Added endpoint) Nov 8, 2017
@AbhiAgarwal
Copy link
Member Author

AbhiAgarwal commented Nov 9, 2017

client_name search: http://localhost:8000/api/v1/lists/?client_name=Apple

tag search: http://localhost:8000/api/v1/lists/?tags__name=apple

@juliepanda
Copy link

juliepanda commented Nov 9, 2017

Basics:

  • GET lists
  • POST lists
  • PATCH lists
  • DELETE lists

Existing

  • change /archive
  • add/remove customfields (existing supported but NEW ENDPOINT)
  • reorder fieldsmap
  • turn on/off hidden fields
  • add/remove tags (NEW ENDPOINT)
  • Upload list and give it custom headers to process
  • Upload list and give it clients + tags

New:

  • change /archive, put back has dupes and mess up list ordering
  • client_name search
  • tag search

Cleanups + bugs:

  • put back has dupes and mess up list ordering after archived changed

@juliepanda
Copy link

@AbhiAgarwal

  1. List reordering add a bunch of dupes to fieldsmap. How to do it now?

e.g.
I PATCH /lists/<id> with reordered fieldsmap and a fieldsmap of double its size comes back.

{"included":{},"data":{"updated":1510343209,"fileupload":17,"name":"demo------c","subscribed":false,"created":1510266374,"archived":false,"clients":[],"contacts":[607,608,609],"publiclist":false,"teamid":1,"client":"","isdeleted":false,"createdby":9,"fieldsmap":[{"readonly":false,"internal":false,"name":"First Name","type":"fields-maps","hidden":false,"customfield":false,"value":"firstname","description":""},{"readonly":false,"internal":false,"name":"Last Name","type":"fields-maps","hidden":false,"customfield":false,"value":"lastname","description":""},{"readonly":false,"internal":false,"name":"Email","type":"fields-maps","hidden":false,"customfield":false,"value":"email","description":""},{"readonly":false,"internal":false,"name":"Employers","type":"fields-maps","hidden":false,"customfield":false,"value":"employers","description":""},{"readonly":false,"internal":false,"name":"Past Employers","type":"fields-maps","hidden":false,"customfield":false,"value":"pastemployers","description":""},{"readonly":false,"internal":false,"name":"Notes","type":"fields-maps","hidden":false,"customfield":false,"value":"notes","description":""},{"readonly":false,"internal":false,"name":"Linkedin","type":"fields-maps","hidden":false,"customfield":false,"value":"linkedin","description":""},{"readonly":false,"internal":false,"name":"Instagram","type":"fields-maps","hidden":false,"customfield":false,"value":"instagram","description":""},{"readonly":false,"internal":false,"name":"Website","type":"fields-maps","hidden":false,"customfield":false,"value":"website","description":""},{"readonly":false,"internal":false,"name":"Blog","type":"fields-maps","hidden":false,"customfield":false,"value":"blog","description":""},{"readonly":false,"internal":false,"name":"Phone #","type":"fields-maps","hidden":false,"customfield":false,"value":"phonenumber","description":""},{"readonly":false,"internal":false,"name":"Location","type":"fields-maps","hidden":false,"customfield":false,"value":"location","description":""},{"readonly":false,"internal":false,"name":"Instagram Followers","type":"fields-maps","hidden":true,"customfield":true,"value":"instagramfollowers","description":""},{"readonly":false,"internal":false,"name":"Instagram Following","type":"fields-maps","hidden":true,"customfield":true,"value":"instagramfollowing","description":""},{"readonly":false,"internal":false,"name":"Instagram Likes","type":"fields-maps","hidden":true,"customfield":true,"value":"instagramlikes","description":""},{"readonly":false,"internal":false,"name":"Instagram Comments","type":"fields-maps","hidden":true,"customfield":true,"value":"instagramcomments","description":""},{"readonly":false,"internal":false,"name":"Instagram Posts","type":"fields-maps","hidden":true,"customfield":true,"value":"instagramposts","description":""},{"readonly":false,"internal":false,"name":"Twitter Followers","type":"fields-maps","hidden":true,"customfield":true,"value":"twitterfollowers","description":""},{"readonly":false,"internal":false,"name":"Twitter Following","type":"fields-maps","hidden":true,"customfield":true,"value":"twitterfollowing","description":""},{"readonly":false,"internal":false,"name":"Twitter Likes","type":"fields-maps","hidden":true,"customfield":true,"value":"twitterlikes","description":""},{"readonly":false,"internal":false,"name":"Twitter Reweets","type":"fields-maps","hidden":true,"customfield":true,"value":"twitterretweets","description":""},{"readonly":false,"internal":false,"name":"Twitter Posts","type":"fields-maps","hidden":true,"customfield":true,"value":"twitterposts","description":""},{"readonly":false,"internal":false,"name":"Latest Headline","type":"fields-maps","hidden":true,"customfield":true,"value":"latestheadline","description":""},{"readonly":false,"internal":false,"name":"Last Contacted","type":"fields-maps","hidden":true,"customfield":true,"value":"lastcontacted","description":""},{"readonly":false,"internal":false,"name":"Publication Last Contacted","type":"fields-maps","hidden":true,"customfield":true,"value":"publicationlastcontacted","description":""},{"readonly":false,"internal":false,"name":"Last Name","type":"fields-maps","hidden":false,"customfield":false,"value":"lastname","description":""},{"readonly":false,"internal":false,"name":"First Name","type":"fields-maps","hidden":false,"customfield":false,"value":"firstname","description":""},{"readonly":false,"internal":false,"name":"Email","type":"fields-maps","hidden":false,"customfield":false,"value":"email","description":""},{"readonly":false,"internal":false,"name":"Employers","type":"fields-maps","hidden":false,"customfield":false,"value":"employers","description":""},{"readonly":false,"internal":false,"name":"Past Employers","type":"fields-maps","hidden":false,"customfield":false,"value":"pastemployers","description":""},{"readonly":false,"internal":false,"name":"Notes","type":"fields-maps","hidden":false,"customfield":false,"value":"notes","description":""},{"readonly":false,"internal":false,"name":"Linkedin","type":"fields-maps","hidden":false,"customfield":false,"value":"linkedin","description":""},{"readonly":false,"internal":false,"name":"Instagram","type":"fields-maps","hidden":false,"customfield":false,"value":"instagram","description":""},{"readonly":false,"internal":false,"name":"Website","type":"fields-maps","hidden":false,"customfield":false,"value":"website","description":""},{"readonly":false,"internal":false,"name":"Blog","type":"fields-maps","hidden":false,"customfield":false,"value":"blog","description":""},{"readonly":false,"internal":false,"name":"Phone #","type":"fields-maps","hidden":false,"customfield":false,"value":"phonenumber","description":""},{"readonly":false,"internal":false,"name":"Location","type":"fields-maps","hidden":false,"customfield":false,"value":"location","description":""},{"readonly":false,"internal":false,"name":"Instagram Followers","type":"fields-maps","hidden":true,"customfield":false,"value":"instagramfollowers","description":""},{"readonly":false,"internal":false,"name":"Instagram Following","type":"fields-maps","hidden":true,"customfield":false,"value":"instagramfollowing","description":""},{"readonly":false,"internal":false,"name":"Instagram Likes","type":"fields-maps","hidden":true,"customfield":false,"value":"instagramlikes","description":""},{"readonly":false,"internal":false,"name":"Instagram Comments","type":"fields-maps","hidden":true,"customfield":false,"value":"instagramcomments","description":""},{"readonly":false,"internal":false,"name":"Instagram Posts","type":"fields-maps","hidden":true,"customfield":false,"value":"instagramposts","description":""},{"readonly":false,"internal":false,"name":"Twitter Followers","type":"fields-maps","hidden":true,"customfield":false,"value":"twitterfollowers","description":""},{"readonly":false,"internal":false,"name":"Twitter Following","type":"fields-maps","hidden":true,"customfield":false,"value":"twitterfollowing","description":""},{"readonly":false,"internal":false,"name":"Twitter Likes","type":"fields-maps","hidden":true,"customfield":false,"value":"twitterlikes","description":""},{"readonly":false,"internal":false,"name":"Twitter Reweets","type":"fields-maps","hidden":true,"customfield":false,"value":"twitterretweets","description":""},{"readonly":false,"internal":false,"name":"Twitter Posts","type":"fields-maps","hidden":true,"customfield":false,"value":"twitterposts","description":""},{"readonly":false,"internal":false,"name":"Latest Headline","type":"fields-maps","hidden":true,"customfield":false,"value":"latestheadline","description":""},{"readonly":false,"internal":false,"name":"Last Contacted","type":"fields-maps","hidden":true,"customfield":false,"value":"lastcontacted","description":""},{"readonly":false,"internal":false,"name":"Publication Last Contacted","type":"fields-maps","hidden":true,"customfield":false,"value":"publicationlastcontacted","description":""},{"readonly":false,"internal":false,"name":"Last Name","type":"fields-maps","hidden":false,"customfield":false,"value":"lastname","description":""},{"readonly":false,"internal":false,"name":"Email","type":"fields-maps","hidden":false,"customfield":false,"value":"email","description":""},{"readonly":false,"internal":false,"name":"Employers","type":"fields-maps","hidden":false,"customfield":false,"value":"employers","description":""},{"readonly":false,"internal":false,"name":"First Name","type":"fields-maps","hidden":false,"customfield":false,"value":"firstname","description":""},{"readonly":false,"internal":false,"name":"Past Employers","type":"fields-maps","hidden":false,"customfield":false,"value":"pastemployers","description":""},{"readonly":false,"internal":false,"name":"Notes","type":"fields-maps","hidden":false,"customfield":false,"value":"notes","description":""},{"readonly":false,"internal":false,"name":"Linkedin","type":"fields-maps","hidden":false,"customfield":false,"value":"linkedin","description":""},{"readonly":false,"internal":false,"name":"Instagram","type":"fields-maps","hidden":false,"customfield":false,"value":"instagram","description":""},{"readonly":false,"internal":false,"name":"Website","type":"fields-maps","hidden":false,"customfield":false,"value":"website","description":""},{"readonly":false,"internal":false,"name":"Blog","type":"fields-maps","hidden":false,"customfield":false,"value":"blog","description":""},{"readonly":false,"internal":false,"name":"Phone #","type":"fields-maps","hidden":false,"customfield":false,"value":"phonenumber","description":""},{"readonly":false,"internal":false,"name":"Location","type":"fields-maps","hidden":false,"customfield":false,"value":"location","description":""},{"readonly":false,"internal":false,"name":"Instagram Followers","type":"fields-maps","hidden":true,"customfield":false,"value":"instagramfollowers","description":""},{"readonly":false,"internal":false,"name":"Instagram Following","type":"fields-maps","hidden":true,"customfield":false,"value":"instagramfollowing","description":""},{"readonly":false,"internal":false,"name":"Instagram Likes","type":"fields-maps","hidden":true,"customfield":false,"value":"instagramlikes","description":""},{"readonly":false,"internal":false,"name":"Instagram Comments","type":"fields-maps","hidden":true,"customfield":false,"value":"instagramcomments","description":""},{"readonly":false,"internal":false,"name":"Instagram Posts","type":"fields-maps","hidden":true,"customfield":false,"value":"instagramposts","description":""},{"readonly":false,"internal":false,"name":"Twitter Followers","type":"fields-maps","hidden":true,"customfield":false,"value":"twitterfollowers","description":""},{"readonly":false,"internal":false,"name":"Twitter Following","type":"fields-maps","hidden":true,"customfield":false,"value":"twitterfollowing","description":""},{"readonly":false,"internal":false,"name":"Twitter Likes","type":"fields-maps","hidden":true,"customfield":false,"value":"twitterlikes","description":""},{"readonly":false,"internal":false,"name":"Twitter Reweets","type":"fields-maps","hidden":true,"customfield":false,"value":"twitterretweets","description":""},{"readonly":false,"internal":false,"name":"Twitter Posts","type":"fields-maps","hidden":true,"customfield":false,"value":"twitterposts","description":""},{"readonly":false,"internal":false,"name":"Latest Headline","type":"fields-maps","hidden":true,"customfield":false,"value":"latestheadline","description":""},{"readonly":false,"internal":false,"name":"Last Contacted","type":"fields-maps","hidden":true,"customfield":false,"value":"lastcontacted","description":""},{"readonly":false,"internal":false,"name":"Publication Last Contacted","type":"fields-maps","hidden":true,"customfield":false,"value":"publicationlastcontacted","description":""}],"type":"lists","id":123,"tags":[],"readonly":false}}

@juliepanda
Copy link

@AbhiAgarwal
2. Uploading a list and adding a customfield during upload doesn't work.

@AbhiAgarwal
Copy link
Member Author

AbhiAgarwal commented Nov 10, 2017

@juliepanda the second issue should be fixed (news-ai/tabulae-v2#46) (2. Uploading a list and adding a customfield during upload doesn't work.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants