Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Photos timeline #7451

Closed
1 of 2 tasks
axellebot opened this issue Nov 23, 2020 · 19 comments
Closed
1 of 2 tasks

Add Photos timeline #7451

axellebot opened this issue Nov 23, 2020 · 19 comments
Labels

Comments

@axellebot
Copy link

axellebot commented Nov 23, 2020

Is your feature request related to a problem? Please describe.

The Photos section can look way more friendly to let user quickly find a Photo based on date just by scrolling the gallery (month, date).

Describe the solution you'd like

Implementing a timeline for Photos section (as Google Photo)

Features :

Additional context

@axellebot
Copy link
Author

axellebot commented Nov 23, 2020

Looping in @tobiasKaminsky

@jakobroehrl
Copy link

see here, too: #6297

@tobiasKaminsky
Copy link
Member

image

We have sort of header already in activities stream.

@skjnldsv @jancborchardt what do you think? This would also be great on server photo app, or?

@tobiasKaminsky
Copy link
Member

Can close this one then ? thinking

No :-)
Thisis then about sectioned header and the other about fast scroll. 👍

@axellebot
Copy link
Author

This might help

@AndyScherzinger
Copy link
Member

@tobiasKaminsky @axellebot please keep in mind that the media screen loads the photos/video-thumbs from the server ordered by date in a block-like way, so it only loads the first 45 and then fetches the next block upon scrolling.

So:

  • implementing a fast scroll only makes sense if one would know there are many images and them being loaded as items into the recycler/adapter
  • a timeline view is possible but might look unnecessary for e.g. the first 3 batches in case they all have the exact same date (but this might just be a small issue)

@axellebot
Copy link
Author

axellebot commented Nov 23, 2020

implementing a fast scroll only makes sense if one would know there are many images and them being loaded as items into the recycler/adapter

I was thinking about it, that's why for me I will not refer to this in here anymore.

a timeline view is possible but might look unnecessary for e.g. the first 3 batches in case they all have the exact same date (but this might just be a small issue)

In my opinion if I only have 3 image at the same date, I will not be mad because I'm seing a section header, but anyway it seems to be a small UI issue.

The section header can also be sync with the 3 scale from the grid view (pinch in/out).
For example :

  • 1st scale : month date
  • 2nd scale : month date
  • 3rd scale : day date

FYI :

@AndyScherzinger
Copy link
Member

Nice work on the server-side webUI, does it provide a nice(r) API to access such infos since this is probably a discussion with @tobiasKaminsky since the media (renamed from photos) is simply using a search query for "photos n videos" with a 45 elements block size when reading the files doesn't provide much help for such a timeline scenario or would you simply implement this based on the 45 images per request on scrolling down logic?

@AndyScherzinger
Copy link
Member

I'd love to have the timeline(d) view BTW 🎉

@tobiasKaminsky
Copy link
Member

Timeline with sectioned header can be adjusted while loading more images.
As it is always from new -> old, it should work nicely.
Same for the fast scroll.

Of course if you have 200 from today, and load only 150, then this does not help.
But if you have only 2-10 images per day, you will have after 4x loading (each 60 images I think) = 240 images, which then might be the last 30 days.

@AndyScherzinger
Copy link
Member

Sure thing 👍

@axellebot
Copy link
Author

axellebot commented Aug 26, 2022

Nice ! Looks like basic sections have been added.
Still need to change section type (month/day) depending on zoom scale.

@rhatguy
Copy link

rhatguy commented Sep 1, 2022

What date is being used to generate the timeline? I have a picture that was scanned from paper and hence I don't know the date it was taken. I had taken an approach of tagging my "unknown" pictures in digikam with a creation time in the year 1902 thinking they would get pushed to the bottom of the timeline, however I changed/modified the picture (tagged a face through digikam) a few days back and now the picture is showing up in the current month on my android phone. Is the modification date being used for the timeline? Any way to cause it to use the creation dates shown below as exported from exiftool?

File Modification Date/Time : 2022:08:13 21:14:06-04:00
File Access Date/Time : 2022:08:27 20:01:08-04:00
File Inode Change Date/Time : 2022:08:27 20:01:09-04:00
Date/Time Modified : 1902:01:01 01:01:01
Create Date : 1902:01:01 01:01:01
Metadata Date : 1902:01:01 01:01:01
Date UTC : 2014:06:27 21:09:33
Modification Date : 2014:06:27 21:09:33

@tobiasKaminsky
Copy link
Member

https://github.com/nextcloud/android/blob/master/app/src/main/java/com/owncloud/android/ui/adapter/GalleryAdapter.kt#L204

@axellebot
Copy link
Author

axellebot commented Sep 2, 2022

I hope timeline will be able to sort photos mainly by "date taken" date from metadata in anytime soon. It needs new server API feature to do so, right ?

@tobiasKaminsky
Copy link
Member

Once we have this info we can use it, and fall back to modification time, if "date taken" from exif is not present.

@Krautmaster
Copy link

will it be indexed? Currently it only shows the timeline of 2 Month for me, while there are images from 2000 onwards. If i scroll down it gets added but not persitent

@joshtrichards joshtrichards added the hotspots: metadata Metadata (EXIF, GPS, etc.) label Dec 6, 2023
@PhilippSchlesinger
Copy link

There is a separate issue #10425 regarding sorting by "date taken".

A corresponding issue nextcloud/photos#87 in Nextcloud Photos got closed via PR nextcloud/photos#2125 recently.
This is part of nextcloud/server#40676 which makes metadata available via API for android as well.

@joshtrichards
Copy link
Member

Fixed in #10050

There are other Issues covering further refinements/enhancements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants