Shared calender not active by default?!

[Dubidubiduu]

Steps to reproduce

1. Share a calender to a group

Expected behaviour

User of that group should get an active calender, i.e. don't need to click on that calender so the circle changes from grey to color.

Actual behaviour

The calender is not active, so the user also doesn't get the events in the dashboard.

Why is that a problem

I then need to activate that calender for every new user by myself.

Calendar: 2.2.0

[diemelone]

same problem

[burnoutberni]

Same. I found this piece of code, which seems to be the place to fix this. Question is though, did someone think of the current behavior and came up with it on purpose or can we just change this?

calendar/src/models/calendar.js

Lines 116 to 129 in 37a0cf5

	let enabled
	if (!currentUserPrincipal) {
	// If the user is not authenticated,
	// always enable the calendar
	enabled = true
	} else if (typeof calendar.enabled === 'boolean') {
	// If calendar-enabled is set, we will just take that
	enabled = calendar.enabled
	} else {
	// If there is no calendar-enabled,
	// we will display the calendar by default if it's owned by the user
	// or hide it by default it it's just shared with them
	enabled = !isSharedWithMe
	}

[ChristophWurst]

did someone think of the current behavior and came up with it on purpose or can we just change this

Hmmmm. Let's see.

f3ec278 added the code. I'd say it's rather clear that this behavior was intended. Nevertheless I can't find the reasoning behind the decision. @tcitworld do you know more?

[tcitworld]

It's possible that since we can't accept calendar shares yet this was made to avoid finding yourself directly with events from calendars that were shared by error.

The issue is that we don't save the calendar-enabled property when creating a calendar, hence this fallback. #1588

Seems to me the perfect way to solve the issue would to implement accepting calendar shares nextcloud/server#19568 nextcloud/server#20096, but in the meantime, I do not have strong opinions on whether or not to activate shared calendars by default.

[burnoutberni]

Thanks for your input. I generally see the point/intention behind the current solution, but on the contrary to @tcitworld I do have a strong opinion pro default activation. I'm responsible for a Nextcloud for a non-profit volunteer organization and we currently have a shared calendar, where our volunteers can – in theory – check back to see what's going on. As it currently stands though, we simply cannot convince 200 people with varying levels of activity to enable the shared calendar themselves. This is turn makes it hard to convince the people who should enter their upcoming events to do that, since only those active enough to take the initiative and enable the calendar will be reached – and those tend to be the same people that keep track of events on their own.

If you decide that you don't want this change in behavior, I'll accept that, but I really hope you consider it, since it would make my life much easier.

Btw, my issue would not be solved by implementing the accept/decline calendar shares feature. Our volunteers should not have to do anything by themselves to see shared events.

[diemelone]

I am with @burnoutberni because I am in almost the same situation. Forcing a default activation for every nc installation is probably not the right solution so please consider making it a setting which a admin can preconfigure but every user has the ability to disable it like the notifications.

[tcitworld]

Btw, my issue would not be solved by implementing the accept/decline calendar shares feature. Our volunteers should not have to do anything by themselves to see shared events.

As for file shares, there should be a toggle to auto-accept shares.

[burnoutberni]

I see. But that toggle would be user-specific ("I accept all shares") or global ("all users automatically accept all shares")? In any case, as I understand it, this is more aspirational. If nothing speaks strongly against it, I'd hope that in the meantime we could apply my PR or something similar.

[ChristophWurst]

Good, then let's go with auto enabled for now and see if this bothers anyone.

[ChristophWurst]

Done with #3201

[ChristophWurst]

let's go with auto enabled for now and see if this bothers anyone

Et voila #3306