Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People view does not open photo #1614

Closed
FadeFx opened this issue Jan 26, 2023 · 8 comments
Closed

People view does not open photo #1614

FadeFx opened this issue Jan 26, 2023 · 8 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working

Comments

@FadeFx
Copy link

FadeFx commented Jan 26, 2023

Describe the bug
Ehen in People section i can open the folder of a person, but clicking a preview opens the image viewer, i see the arrows and the "start slideshow" button and the spinner which will never stop spinning and it does not show the image. It does open any of these pics from any other section.

To Reproduce
Open Photos
Open Peoples from sidebar
Click on a persons image
Klick on any pic there
No image in viewer

Expected behavior
See Image in full size

The Dev console output from Chrome will be delivered later, i have seen this issue on mobile phone as well as on desktop.

@FadeFx FadeFx added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Jan 26, 2023
@FadeFx
Copy link
Author

FadeFx commented Jan 26, 2023

Chrome console output

xhr.js:220 PROPFIND https://my.domain.tld/remote.php/dav/files/USERNAME/files/USERNAME/Sync_Handy/Downloads/Fotos/Sebastian%20Schallenberg.png 404
(anonymous) @ xhr.js:220
e.exports @ xhr.js:16
e.exports @ dispatchRequest.js:56
p.request @ Axios.js:109
(anonymous) @ bind.js:9
(anonymous) @ functions.js:21
e.execute @ patcher.js:100
e.patchInline @ patcher.js:199
u @ request.js:13
t.request @ request.js:56
(anonymous) @ stat.js:62
(anonymous) @ stat.js:33
(anonymous) @ stat.js:14
(anonymous) @ stat.js:8
r @ stat.js:4
t.getStat @ stat.js:47
stat @ factory.js:80
(anonymous) @ FileInfo.js:33
u @ runtime.js:63
(anonymous) @ runtime.js:294
(anonymous) @ runtime.js:119
cg @ DavClient.js:38
a @ DavClient.js:38
(anonymous) @ DavClient.js:38
(anonymous) @ DavClient.js:38
dg @ FileInfo.js:32
(anonymous) @ CancelableRequest.js:41
u @ runtime.js:63
(anonymous) @ runtime.js:294
(anonymous) @ runtime.js:119
Qm @ canDownload.js:26
a @ CancelableRequest.js:40
(anonymous) @ CancelableRequest.js:40
(anonymous) @ CancelableRequest.js:40
(anonymous) @ CancelableRequest.js:40
(anonymous) @ Viewer.vue:503
u @ runtime.js:63
(anonymous) @ runtime.js:294
(anonymous) @ runtime.js:119
Ig @ Pencil.vue?12b8:19
a @ Pencil.vue?12b8:19
(anonymous) @ Pencil.vue?12b8:19
(anonymous) @ Pencil.vue?12b8:19
openFile @ Viewer.vue:471
file @ Viewer.vue:355
Pt @ vue.runtime.esm.js:3017
e.run @ vue.runtime.esm.js:3534
yn @ vue.runtime.esm.js:4121
(anonymous) @ vue.runtime.esm.js:3143
Mt @ vue.runtime.esm.js:3065
Promise.then (async)
jt @ vue.runtime.esm.js:3090
Ht @ vue.runtime.esm.js:3155
bn @ vue.runtime.esm.js:4207
e.update @ vue.runtime.esm.js:3513
e.notify @ vue.runtime.esm.js:720
set @ vue.runtime.esm.js:963
value @ Viewer.js:246
openViewer @ FaceContent.vue:288
Rt @ vue.runtime.esm.js:3015
n @ vue.runtime.esm.js:1813
Rt @ vue.runtime.esm.js:3015
e.$emit @ vue.runtime.esm.js:3714
emitClick @ File.vue:185
click @ File.vue?vue&type=template&id=14205f7c&scoped=true&:1
Rt @ vue.runtime.esm.js:3015
n @ vue.runtime.esm.js:1813
Jr.i._wrapper @ vue.runtime.esm.js:7458
Viewer.vue:507 Could not open file /files/USERNAME/Sync_Handy/Downloads/Fotos/Sebastian Schallenberg.png Error: Invalid response: 404
at i (response.js:10:15)
at t.handleResponseCode (response.js:21:19)
at stat.js:65:36
at stat.js:33:23
at Object.next (stat.js:14:53)
at a (stat.js:5:58)
(anonymous) @ Viewer.vue:507
u @ runtime.js:63
(anonymous) @ runtime.js:294
(anonymous) @ runtime.js:119
Ig @ Pencil.vue?12b8:19
s @ Pencil.vue?12b8:19
Promise.then (async)
Ig @ Pencil.vue?12b8:19
a @ Pencil.vue?12b8:19
(anonymous) @ Pencil.vue?12b8:19
(anonymous) @ Pencil.vue?12b8:19
openFile @ Viewer.vue:471
file @ Viewer.vue:355
Pt @ vue.runtime.esm.js:3017
e.run @ vue.runtime.esm.js:3534
yn @ vue.runtime.esm.js:4121
(anonymous) @ vue.runtime.esm.js:3143
Mt @ vue.runtime.esm.js:3065
Promise.then (async)
jt @ vue.runtime.esm.js:3090
Ht @ vue.runtime.esm.js:3155
bn @ vue.runtime.esm.js:4207
e.update @ vue.runtime.esm.js:3513
e.notify @ vue.runtime.esm.js:720
set @ vue.runtime.esm.js:963
value @ Viewer.js:246
openViewer @ FaceContent.vue:288
Rt @ vue.runtime.esm.js:3015
n @ vue.runtime.esm.js:1813
Rt @ vue.runtime.esm.js:3015
e.$emit @ vue.runtime.esm.js:3714
emitClick @ File.vue:185
click @ File.vue?vue&type=template&id=14205f7c&scoped=true&:1
Rt @ vue.runtime.esm.js:3015
n @ vue.runtime.esm.js:1813
Jr.i._wrapper @ vue.runtime.esm.js:7458
index.js:323 OC.requestToken changed ZWqP9Vbi22iCsxnAV6HgdbhcgDUE5cLL5gbApWYpo2I=:UxLCshupry7Gy1CoOMLZLd861VBPhIGJ1XWYwklIzDg=

i have checked the location of the images and it is actually correct, except the path in PROPFIND has /dav/files/USERNAME/files/USERNAME/ where one files/USERNAME/ part is too much and the path in viewer.view should probably be in ' ' because it could contain whitespaces i guess

@shalak
Copy link

shalak commented Feb 2, 2023

Please use proper formatting when pasting logs and check for typos, when you're describing the issues - that way, we'll get more traction on getting devs to fix something :)

The Viewer.vue entry seems unrelated, it just shows a log. The actual path is properly URL-encoded.

But you've noticed the real problem, and I'm seeing the same issue - the 404 on PROPFIND call has duplicated /files/USERNAME/ prefix in path: remote.php/dav/files/USERNAME/files/USERNAME/DirectoryInMyMainFolder

I'm running NextCloud 25.0.3 with Photos 2.0.1, using nextcloud-aio deployment, with Caddy in front of apache.

Seems like this should be a trivial fix 🤔

@zlatko0o
Copy link

zlatko0o commented Feb 3, 2023

I am having the same issue. Once the faces are generated, I cannot open any photos from the selected "Face".

One of the things that I noticed is that the URL is wrong.

The working one is => /remote.php/dav/files/admin/Photos
The URL that the Face preview generates is => /remote.php/dav/files/admin/files/admin/Photos/ notice the double "files/admin"

Also when you click on the photo and move back/forward it seems to be working.

@FadeFx
Copy link
Author

FadeFx commented Feb 4, 2023

"Also when you click on the photo and move back/forward it seems to be working."

Thanx, ddint see that before...

@phil-lipp
Copy link

duplicate of #1594

@marcelklehr
Copy link
Member

This should be fixed in v25.0.4

@vzsze
Copy link

vzsze commented May 16, 2023

I still see this in 26.0.1.

@SunnyDaze
Copy link

Still seeing this bug in 28.0.2 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants