[BITV]: Not possible to add already selected photos to the album via keyboard

[JuliaKirschenheuter]

1. Create an album
2. Try to select some photos and add them to the album via keyboard

It is not possible to reach "Add to ..." and "Add" buttons via keyboard

[JuliaKirschenheuter]

Thanks @Pytal!

[Pytal]

This is a tricky bug as we use focus trap + virtual scrolling here. Focus trap finds the initial tabbable nodes but as you scroll the elements are rerendered and seems to cause the glitch. updateContainerElements does not seem to work, still not sure why though.

According to the focusin event the next node is correctly focused but immediately afterwards the focus is moved to body

Draft semi-working patch to bring back focus to the correct next element in Pytal/focus-trap#1

[Pytal]

Regarding the virtual scrolling part, there is a new related bug with the virtual-scrolled files list where if you have many files and tab past the last file to the start of the page and then back into the list it will focus not on the first file but on the first currently rendered file i.e. 90th file row instead of the first

I believe there was some exception made for infinite scrolling before so maybe not an issue @JuliaKirschenheuter?

[ShGKme]

Can we disable focus-trap here and implement our own simple focus trap?

[Pytal]

Can we disable focus-trap here and implement our own simple focus trap?

Just tried and seems to make it worse, tabbing at the glitch point jumps straight to the bottom instead of the next photo

[JuliaKirschenheuter]

close as done