Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV]: Button "back" is an icon-button and have no alternative text #2239

Closed
JuliaKirschenheuter opened this issue Jan 8, 2024 · 5 comments · Fixed by #2271
Closed

[BITV]: Button "back" is an icon-button and have no alternative text #2239

JuliaKirschenheuter opened this issue Jan 8, 2024 · 5 comments · Fixed by #2271
Assignees
@JuliaKirschenheuter
Labels
1. to develop Accepted and waiting to be taken care of a11y28checked needed for a11y accessibility

Comments

@JuliaKirschenheuter
Copy link
Contributor

Screenshot from 2024-01-08 18-33-09

aria-label have to be there (NcVue only icon button)
@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Jan 8, 2024
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 8, 2024
@JuliaKirschenheuter JuliaKirschenheuter mentioned this issue Jan 22, 2024
Merged
@szaimen
Copy link
Contributor

szaimen commented Feb 5, 2024

The back button seems to be missing now and I cannot open any picture here anymore...
image

@szaimen szaimen reopened this Feb 5, 2024
@susnux
Copy link
Contributor

susnux commented Feb 5, 2024

Its position needs to be absolute instead of fixes I guess

@JuliaKirschenheuter
Copy link
Contributor Author

some other regression? I haven't changed position of the button

@szaimen
Copy link
Contributor

szaimen commented Feb 7, 2024

This is still broken:

Aufzeichnung.2024-02-07.124127.mp4

@szaimen szaimen mentioned this issue Feb 7, 2024
Closed
@szaimen
Copy link
Contributor

szaimen commented Feb 7, 2024

Opened #2321 for that. This issue here issue seems to be fixed :)

@szaimen szaimen closed this as completed Feb 7, 2024
@szaimen szaimen added the a11y28checked needed for a11y label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
1. to develop Accepted and waiting to be taken care of a11y28checked needed for a11y accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing label to "back" button nextcloud/photos
3 participants
@susnux @JuliaKirschenheuter @szaimen