Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] Modal close button overlaps content #2294

Closed
Pytal opened this issue Jan 31, 2024 · 2 comments
Closed

[BITV] Modal close button overlaps content #2294

Pytal opened this issue Jan 31, 2024 · 2 comments
Assignees
@Pytal
Labels
3. to review Waiting for reviews a11y28checked needed for a11y accessibility bug Something isn't working enhancement New feature or request
Milestone
Nextcloud 29

Comments

@Pytal
Copy link
Member

Pytal commented Jan 31, 2024

There are still some modal close buttons which overlap the content

File picker Edit album Rename person
image image image
@Pytal Pytal added bug Something isn't working enhancement New feature or request 1. to develop Accepted and waiting to be taken care of accessibility labels Jan 31, 2024
@Pytal Pytal added this to the Nextcloud 29 milestone Jan 31, 2024
@Pytal Pytal self-assigned this Jan 31, 2024
@Pytal Pytal added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jan 31, 2024
@Pytal Pytal mentioned this issue Jan 31, 2024
Closed
@Pytal
Copy link
Member Author

Pytal commented Jan 31, 2024

❕ File picker was already drafted but addressed in #2287, thanks @susnux!

Handling other modals here

@susnux
Copy link
Contributor

susnux commented Jan 31, 2024

Yeah saw them too but decided to first only migrate the photos picker, see #2296

@Pytal Pytal mentioned this issue Jan 31, 2024
Merged
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 31, 2024
@Pytal Pytal closed this as completed Feb 7, 2024
@szaimen szaimen added the a11y28checked needed for a11y label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews a11y28checked needed for a11y accessibility bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
Nextcloud 29
Development

No branches or pull requests
3 participants
@susnux @Pytal @szaimen