Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required nodejs version is EOL #985

Closed
SuperSandro2000 opened this issue Oct 1, 2023 · 6 comments
Closed

required nodejs version is EOL #985

SuperSandro2000 opened this issue Oct 1, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@SuperSandro2000
Copy link
Contributor

Describe the feature you'd like to request

Right now the admin ui states: Currently supported is Node v14.17 and newer v14 releases.
Nodejs 14 is EOL, see https://endoflife.date/nodejs .

Describe the solution you'd like

It should be upgraded to a newer version like 18.

Describe alternatives you've considered

🤷🏼

@SuperSandro2000 SuperSandro2000 added the enhancement New feature or request label Oct 1, 2023
@SuperSandro2000
Copy link
Contributor Author

I think this is still a problem with 6.0.0. The PHP code still wants to install nodejs 14 https://github.com/nextcloud/recognize/blob/main/lib/Migration/InstallDeps.php#L42-L44 despite the nodejs part already using nodejs 16 https://github.com/nextcloud/recognize/blob/main/package.json#L66.

My distribution removed nodejs 14 and 16 for the next stable release. I have no problem with reverting both and getting them back but I'd imagine other distros will soon have a similar problems were reverting is not always as easy and might demand adding 3rd party sources like nodesource.com which already removed nodejs 14.

@marcelklehr
Copy link
Member

Yes, it still needs to be fixed.

@marcelklehr marcelklehr added bug Something isn't working and removed enhancement New feature or request labels Nov 20, 2023
@marcelklehr marcelklehr changed the title Upgrade required nodejs version required nodejs version is EOL Nov 20, 2023
@espressodriven
Copy link

espressodriven commented Apr 27, 2024

@marcelklehr I just wanted to ask about this, and fix it myself, but it seems to be fixed in commit a0ae4ac already? Thx for your work!

@SuperSandro2000
Copy link
Contributor Author

That's in no release yet according to git.

@espressodriven
Copy link

Yes I know that, but what I meant is that I can't help by creating a fix and a pull request for that issue myself, since it is already fixed upstream.
@marcelklehr Could you share a preliminary release date for a version which includes this fix?

@marcelklehr
Copy link
Member

This will be fixed with v7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants