Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.app-content-list needs minimum width constraint #12453

Closed
MeCias opened this issue Oct 19, 2018 · 10 comments
Closed

.app-content-list needs minimum width constraint #12453

MeCias opened this issue Oct 19, 2018 · 10 comments
Labels
design Design, UI, UX, etc.
Milestone

Comments

@MeCias
Copy link

MeCias commented Oct 19, 2018

Hello,

after the last update to 0.11.0 I noticed a difference to the layout of the email app that apparently I am not able to adjust. The middle column, where usually the emails are listed, is too narrow all of the sudden.

I am using NC 14.0.3 and have tested it with Firefox 62 and 63. Same behavior.

screenshot

@ChristophWurst
Copy link
Member

I cannot reproduce this all the time, but it happens for me as well sometimes with folders other than the unified inbox.

@ChristophWurst
Copy link
Member

@jancborchardt could you have a look please?

@BinkaDroid
Copy link

As a workaround I did a change to "mail/css/mail.scss" by adding
.app-content-list { min-width:300px; }
which overrides
.app-content-list { max-width:300px; }
from "nextcloud/core/css/server.scss"

@Kugeleis
Copy link

same here: depending on the actual mail selected the middle column shrinks or expands. I could not detect a pattern. Tested with firefox & opera.

@jancborchardt
Copy link
Member

jancborchardt commented Oct 23, 2018

Can confirm too lots of times, but also am not sure about the pattern. Possibly HTML mails are forcing the width?

Probably having some sort of min-width for .app-content-list is a good idea anyway? @skjnldsv
Also, the width of that column should not really change during runtime. Maybe it should rather have its width set through percentage or vw? (Edit: vw → viewport width, CSS unit ;)

@ChristophWurst
Copy link
Member

vw?

🚗?

@skjnldsv
Copy link
Member

Yes you can do this:

flex: 1 1;
min-width: 300px;
max-width: 350px;

@ChristophWurst
Copy link
Member

flex: 1 1; min-width: 300px; max-width: 350px;

Works 👍 However different min/max values still cause the column to jump from narrow to wide depending on the selected message. I think the pattern is messages with long sentenses that cause line breaks and therefore the container to expand its width.

@skjnldsv should we fix this in Mail or the server?

@ChristophWurst
Copy link
Member

I think the pattern is messages with long sentenses that cause line breaks and therefore the container to expand its width.

Confirming my own suspicion: just add a very long text to the .app-content and its width will expand.

@ChristophWurst ChristophWurst changed the title The email column is too narrow. .app-content-list needs minimum width constraint Nov 14, 2018
@rullzer rullzer transferred this issue from nextcloud/mail Nov 14, 2018
@nextcloud-bot nextcloud-bot added the design Design, UI, UX, etc. label Nov 14, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #11403 (The app content width is forced to the app navigation width in IE 11), #6612 (Provide guidelines for app-content lists), #8361 (News App: Configurable/Dynamic width of the feed list), #1979 (Need a nice app icon for share by mail), and #10881 (Makes the notifications area width equal to the contents).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design, UI, UX, etc.
Projects
None yet
Development

No branches or pull requests

8 participants