Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] (CalDav): Last occurrence date is not calculated properly on recurring events #45489

Closed
SebastianKrupinski opened this issue May 23, 2024 · 4 comments
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish 30-feedback bug feature: caldav Related to CalDAV internals

Comments

@SebastianKrupinski
Copy link
Contributor

The last occurrence date is NOT calculated properly on recurring events causing notification emails for changes and cancellation not to be sent.

// don't send out mails for events that already took place
$lastOccurrence = $this->imipService->getLastOccurrence($iTipMessage->message);
$currentTime = $this->timeFactory->getTime();
if ($lastOccurrence < $currentTime) {
return;
}

@SebastianKrupinski
Copy link
Contributor Author

Confirmed.

Tested using a every 2 days event that was recurring for two weeks, then cancelling the event after the second occurrence had passed.

@SebastianKrupinski SebastianKrupinski added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label May 23, 2024
@SebastianKrupinski SebastianKrupinski moved this from 📄 To do to 🏗️ In progress in 💌 📅 👥 Groupware team May 28, 2024
@SebastianKrupinski
Copy link
Contributor Author

Determined Cause.

The cause is the parseEventForOrganizer function in sabre/vobject/lib/ITip/Broker class that generates the iTip messages.

The function does not include the RRULE parameter as part of the iTipMessage->message->VEVENT that is sent to the scheduler.

Therefore the last occurrence cannot be calculated properly.

Possible fixes...

  • remove last occurrence test
  • update sabre dav repo

@ChristophWurst ChristophWurst added feature: caldav Related to CalDAV internals 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jun 6, 2024
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Oct 2, 2024
@ChristophWurst
Copy link
Member

#47998 is in so this can be resumed

@SebastianKrupinski
Copy link
Contributor Author

Confirmed fixed with #48583

RRULE is now present when cancelling an event series after the first occurance.

Image

@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Oct 21, 2024
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish 30-feedback bug feature: caldav Related to CalDAV internals
Projects
Development

No branches or pull requests

3 participants