Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling an event via Status Dropdown doesn't send iMIP CANCEL request #46719

Closed
4 of 8 tasks
pabzm opened this issue Jul 24, 2024 · 7 comments
Closed
4 of 8 tasks

Cancelling an event via Status Dropdown doesn't send iMIP CANCEL request #46719

pabzm opened this issue Jul 24, 2024 · 7 comments
Assignees
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback bug feature: caldav Related to CalDAV internals feature: dav upstream

Comments

@pabzm
Copy link
Contributor

pabzm commented Jul 24, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

The email notification for an event that was cancelled only says that the event was updated, it does not show the status "cancelled". Thus the email looks as if some other attribute (e.g. the time) was changed, which is confusing.

Steps to reproduce

  1. Create an event with an attendee.
  2. Save it.
  3. Open it, set status to cancelled.
  4. Save it.
  5. See email notification.

Expected behavior

The email notification should tell me that the event was cancelled.

Installation method

None

Nextcloud Server version

29 (29.0.4.1 on c.nc.com)

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@pabzm pabzm added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jul 24, 2024
@pabzm pabzm changed the title [Bug]: Email notification for cancelled event does not show cancelled state [Bug]: Email notification for cancelled event does not show cancelled status Jul 24, 2024
@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jul 24, 2024
@ChristophWurst ChristophWurst added feature: dav feature: caldav Related to CalDAV internals labels Jul 24, 2024
@ChristophWurst
Copy link
Member

The email notification for an event that was cancelled only says that the event was updated, it does not show the status "cancelled". Thus the email looks as if some other attribute (e.g. the time) was changed, which is confusing.

To add to the confusion: if only the even status changed, it will show the SUMMARY (title) as changed.

@miaulalala miaulalala self-assigned this Aug 28, 2024
@miaulalala
Copy link
Contributor

The issue is that modifying the state is not actually sending a CANCEL but a REQUEST.

@miaulalala miaulalala changed the title [Bug]: Email notification for cancelled event does not show cancelled status Cancelling an event via Status Dropdown doesn't send iMIP CANCEL request Aug 28, 2024
@SebastianKrupinski
Copy link
Contributor

This is what happens when the status is used.

BEGIN:VCALENDAR
CALSCALE:GREGORIAN
VERSION:2.0
PRODID:-//IDN nextcloud.com//Calendar app 5.0.0-alpha.4//EN

BEGIN:VEVENT
CREATED:20240827T174104Z
DTSTAMP:20240828T145808Z
LAST-MODIFIED:20240828T145808Z
SEQUENCE:3
UID:762730a7-09a2-466e-b80a-b655b94fed06
DTSTART;TZID=America/Toronto:20240906T100000
DTEND;TZID=America/Toronto:20240906T110000

STATUS:CANCELLED

SUMMARY:This is a test
ATTENDEE;CN=User 2;CUTYPE=INDIVIDUAL;PARTSTAT=NEEDS-ACTION;ROLE=REQ-PARTICI
 PANT;RSVP=TRUE;LANGUAGE=en;SCHEDULE-STATUS=5.0:mailto:[email protected]
ORGANIZER;CN=User 1:mailto:[email protected]
END:VEVENT

END:VCALENDAR

Issue is with the iTipBroker its generating a request instead of a cancelled message.

image

@SebastianKrupinski
Copy link
Contributor

Tested a fix.

The change required is in the Sabre\VObject\ITip\Broker:506, currently there is no test for events with a CANCELLED status property...

if (!$attendee['newInstances']) 

changing this to...

if (!$attendee['newInstances'] || $eventInfo['status'] === 'CANCELLED')

Fixes the issue and generates proper CANCEL messages.

image

@SebastianKrupinski
Copy link
Contributor

Upstream PR: sabre-io/vobject#669

@SebastianKrupinski SebastianKrupinski added upstream and removed 1. to develop Accepted and waiting to be taken care of 29-feedback labels Aug 28, 2024
@szaimen szaimen added 0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback labels Aug 29, 2024
@phil-davis
Copy link
Contributor

Fix has been released in https://github.com/sabre-io/vobject/releases/tag/4.5.6
which also supports upcoming PHP 8.4

@SebastianKrupinski
Copy link
Contributor

Confirmed fixed with #48583

iTip messages are now generated when changing the event STATUS to CANCELLED.

@github-project-automation github-project-automation bot moved this from 📄 To do to ☑️ Done in 💌 📅 👥 Groupware team Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback bug feature: caldav Related to CalDAV internals feature: dav upstream
Projects
Development

No branches or pull requests

6 participants