Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Twitter Meta Tags #49871

Open
solonovamax opened this issue Dec 15, 2024 · 1 comment · May be fixed by #49872
Open

Add Twitter Meta Tags #49871

solonovamax opened this issue Dec 15, 2024 · 1 comment · May be fixed by #49872
Labels

Comments

@solonovamax
Copy link

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
Currently, Nextcloud does not use any twitter meta tags.
This causes embeds/link previews on sites that use those tags to not look as nice, specifically when sharing a link to an image.

For example, on twitter:
Image
or on discord:
Image

In this (preview for a) post, the url https://nextcloud.solonovamax.gay/s/4k7ykyBZWtsozBy is linked. I would expect that it renders a large thumbnail showing the full image, rather than just a small thumbnail.

Describe the solution you'd like
Adding the twitter:card meta tag with the value of summary_large_image when linking to an image.

Here's how I would expect it to look on discord (This was created using a "discord embed editor", plus a couple of changes to the css/html to have to look similar, which is why certain elements may not look identical):
Image

Describe alternatives you've considered
Not adding the twitter:card meta tag.

Additional context
N/A

@solonovamax solonovamax added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Dec 15, 2024
@solonovamax
Copy link
Author

I'm going to PR a change that solves this in a few.

solonovamax added a commit to solonovamax/server that referenced this issue Dec 15, 2024
Adds the following twitter meta tags
- `twitter:title`: same as `og:title`
- `twitter:description`: same as `og:description`
- `twitter:card`: `summary_large_image` if the shared file is an image & it has a preview, otherwise `summary`
- `twitter:image`: same as `og:image`

Fixes nextcloud#49871
solonovamax added a commit to solonovamax/server that referenced this issue Dec 15, 2024
Adds the following twitter meta tags
- `twitter:title`: same as `og:title`
- `twitter:description`: same as `og:description`
- `twitter:card`: `summary_large_image` if the shared file is an image & it has a preview, otherwise `summary`
- `twitter:image`: same as `og:image`

Fixes nextcloud#49871

Signed-off-by: solonovamax <[email protected]>
solonovamax added a commit to solonovamax/server that referenced this issue Dec 15, 2024
Adds the following twitter meta tags
- `twitter:title`: same as `og:title`
- `twitter:description`: same as `og:description`
- `twitter:card`: `summary_large_image` if the shared file is an image & it has a preview, otherwise `summary`
- `twitter:image`: same as `og:image`

Fixes nextcloud#49871

Signed-off-by: solonovamax <[email protected]>
@solonovamax solonovamax linked a pull request Dec 15, 2024 that will close this issue
6 tasks
@solracsf solracsf linked a pull request Dec 15, 2024 that will close this issue
6 tasks
@solracsf solracsf added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 15, 2024
solonovamax added a commit to solonovamax/server that referenced this issue Dec 15, 2024
Adds the following twitter meta tags
- `twitter:title`: same as `og:title`
- `twitter:description`: same as `og:description`
- `twitter:card`: `summary_large_image` if the shared file is an image & it has a preview, otherwise `summary`
- `twitter:image`: same as `og:image`

Fixes nextcloud#49871

Signed-off-by: solonovamax <[email protected]>
solonovamax added a commit to solonovamax/server that referenced this issue Dec 15, 2024
Adds the following twitter meta tags
- `twitter:title`: same as `og:title`
- `twitter:description`: same as `og:description`
- `twitter:card`: `summary_large_image` if the shared file is an image & it has a preview, otherwise `summary`
- `twitter:image`: same as `og:image`

Fixes nextcloud#49871

Signed-off-by: solonovamax <[email protected]>
solonovamax added a commit to solonovamax/server that referenced this issue Dec 15, 2024
Adds the following twitter meta tags
- `twitter:card`: `summary_large_image` if the shared file is an image & it has a preview, otherwise `summary`
- `twitter:title`: same as `og:title`
- `twitter:description`: same as `og:description`
- `twitter:image`: same as `og:image`

Fixes nextcloud#49871

Signed-off-by: solonovamax <[email protected]>
solonovamax added a commit to solonovamax/server that referenced this issue Dec 16, 2024
Adds the following twitter meta tags
- `twitter:card`: `summary_large_image` if the shared file is an image & it has a preview, otherwise `summary`
- `twitter:title`: same as `og:title`
- `twitter:description`: same as `og:description`
- `twitter:image`: same as `og:image`

Fixes nextcloud#49871

Signed-off-by: solonovamax <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@solracsf @solonovamax and others