Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Migrate Litmus and CalDAVTester from drone to GitHub #45619

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 2, 2024

Summary

Migrate the last two remaining CI tests from drone to GitHub CI. Allowing us to shut down drone workers.

TODO

  • Remove drone from the required checks

Checklist

@susnux susnux force-pushed the chore/migrate-litmus branch 17 times, most recently from 5d835a1 to 5fb1e7b Compare June 2, 2024 15:11
@susnux susnux added 3. to review Waiting for reviews CI labels Jun 2, 2024
@susnux susnux added this to the Nextcloud 30 milestone Jun 2, 2024
@susnux
Copy link
Contributor Author

susnux commented Jun 2, 2024

/backport to stable29

@susnux susnux changed the title Chore/migrate litmus ci: Migrate Litmus and CalDAVTester from drone to GitHub Jun 2, 2024
@susnux susnux force-pushed the chore/migrate-litmus branch 5 times, most recently from 73f26c4 to a150c29 Compare June 2, 2024 16:50
@susnux susnux requested review from ChristophWurst and st3iny June 2, 2024 16:50
@susnux susnux requested a review from skjnldsv June 2, 2024 16:50
@susnux susnux marked this pull request as ready for review June 2, 2024 16:50
@susnux susnux requested a review from nickvergessen as a code owner June 2, 2024 16:50
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good to me!


ERROR: There were 1 missing files:
.drone.yml
ERROR: Please remove or add those files again or inform the release team about those now files to be included or excluded from the release tar ball.

Perhaps removing the file from https://github.com/nextcloud/server/blob/master/build/files-checker.php is sufficient?

Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👏

@susnux susnux force-pushed the chore/migrate-litmus branch from a150c29 to 4f9dba7 Compare June 3, 2024 23:21
@susnux susnux requested a review from st3iny June 3, 2024 23:30
@@ -8,7 +8,6 @@
'.',
'..',
'.devcontainer',
'.drone.yml',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

susnux added 2 commits June 8, 2024 15:19
Signed-off-by: Ferdinand Thiessen <[email protected]>
We can finally shut of drone workers.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the chore/migrate-litmus branch from 4f9dba7 to dc9df43 Compare June 8, 2024 13:20
@susnux
Copy link
Contributor Author

susnux commented Jun 8, 2024

@nickvergessen I resolved you comments, when merging you need to remove drone from the required checks.

@skjnldsv skjnldsv merged commit d2f0962 into master Jun 8, 2024
166 checks passed
@skjnldsv skjnldsv deleted the chore/migrate-litmus branch June 8, 2024 14:58
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from Drone to GitHub Actions
5 participants