Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: nextclade extensions to display multiple nomenclatures #59

Open
j23414 opened this issue May 31, 2024 · 3 comments
Open

ENH: nextclade extensions to display multiple nomenclatures #59

j23414 opened this issue May 31, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@j23414
Copy link
Contributor

j23414 commented May 31, 2024

Context

To be written

Description

TBD

Examples

Possible solution

@j23414 j23414 added the enhancement New feature or request label May 31, 2024
@corneliusroemer
Copy link
Member

corneliusroemer commented Oct 16, 2024

Do you mean by this to support the new consensus/consortium lineage nomenclature, i.e. https://doi.org/10.1101/2024.05.16.24307504

There are 4 community datasets now for each serotype that annotate the lineages

@j23414
Copy link
Contributor Author

j23414 commented Oct 16, 2024

Originally written, I meant for this issue to allow multiple lineage nomenclature without having to "pick" a correct one. The user could switch between the nomenclature that makes sense for their use-case.

Oh, I definitely support adding rules (to ingest?) to use the 4 community dataset to annotate lineages. I assume the 4 community datasets are DENV1-DENV4 so this would add a single Hill_et_al_2024_nextclade_lineage_calls column to the metadata? Or 4 separate columns?

Feel free to noodle around and add this, I'm a little buried in wnv and lassa pipeline development for a while.

@corneliusroemer
Copy link
Member

I don't think I've got time right now to do this - interesting idea to use those datasets to annotate lineages, I was thinking rather to add that lineages system to the Nextstrain nextclade dataset as well from first principles (i.e. not relying on another dataset). The advantage of going from first principles is that you get internal node assignments automatically, rather than having to infer them somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants