-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build image based on conda-base? #222
Comments
Copying over my response from Slack: I would consider this. The docker-base image still requires emulation for many programs mostly because the process to cross-compile successfully is kinda painful to figure out and varies for each program. If these programs are already precompiled for multiple platforms in conda, it would be nice to leverage that work. |
Seems reasonable as long as we continue to support tools that are not readily available via conda (mainly thinking of fauna, additional context in conda-base) |
@joverlee521 the simple solution is to just add everything to conda - like Packaging things into bioconda/conda-forge has a clear advantage of making things also more easily available to the whole community. |
+1 for one source of truth, but after trying unsuccessfully to get a TreeKnit Bioconda package built, I'm skeptical that everything we need in the future will be Conda-able. If we do decide to prioritize a single source of truth and the ability to always have a Conda version of every package we need, then we need to enforce stricter guidelines about the tools we can support. The Julia/TreeKnit issue is an obvious one. Another issue would be how Bioconda didn't support ARM64 for several years while we were able to create Docker images with ARM64 support through custom builds quite quickly. |
Actually, we had considered this a bit in #127. @huddlej said:
and @tsibley said:
The new development is that most(?) tools we provide in the runtimes are now available as linux-aarch64 on Bioconda. |
I didn't realize how out of date our pins are compared to conda-base (which is usually using latest versions). There's still this open PR from 15 months ago: #145 The main argument I see for not updating is that there's no need to, and that there's a risk associated with it. Downside is that one can't just use latest features of the tools we package, one needs to look at old versions of their docs. And if one wants to use newer features, like e.g. cmaple iqtree, one needs to make explicit PRs for it, like here #226 Maybe we could make a conda-base based docker image to allow test-driving in a few workflows to see what our experience is. |
@corneliusroemer re: pins, this is a good point for discussion which I've started a separate issue for: #227
For test-driving latest versions of tools, it might be easier to remove the pins in the existing Dockerfile rather than rewriting it to use conda-base. |
Initially proposed by @corneliusroemer on Slack.
Tasks
The text was updated successfully, but these errors were encountered: