Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argument parser in upload.py #83

Open
rneher opened this issue Apr 2, 2018 · 3 comments
Open

argument parser in upload.py #83

rneher opened this issue Apr 2, 2018 · 3 comments

Comments

@rneher
Copy link
Member

rneher commented Apr 2, 2018

the parser is currently instantiated in vdb/upload.py. repeated imports from upload will, therefore, use the exact same parser and addition of arguments in other files generate argument clashes. code following this line

https://github.com/nextstrain/fauna/blob/master/vdb/upload.py#L9

should be wrapped into a function get_parser() or similar.

@4rund3v
Copy link

4rund3v commented Mar 31, 2020

I think i can work on this , if this is still relavent.

@jstoja
Copy link

jstoja commented Apr 4, 2020

I don't think this is relevant anymore as it is described since it has been wrapped already.
Although, reading through vdb/download.py, It seems that it's doing a lot of parsing of the arguments. This probably could be extracted to a vdb/parser.py.

@tjGhani
Copy link

tjGhani commented Jun 29, 2020

@rneher @trvrb I believe this issue can be closed since the issue seems resolved and the parser is wrapped in a function, as originally suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants