Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While doing a release, it seems the dataset that's getting released is broken (getting 404) #235

Open
corneliusroemer opened this issue Oct 17, 2024 · 2 comments

Comments

@corneliusroemer
Copy link
Member

I've noticed that while the release is ongoing for SARS-CoV-2, the new dataset is selectable, but when you click on it you get a 404 due to README and CHANGELOG not being available.

Google Chrome 2024-10-17 18 55 56 Google Chrome 2024-10-17 18 56 11

This seems to be only happening while the release action is running.

@corneliusroemer
Copy link
Member Author

Now things work again - so it seems to be an issue for a short time only - probably not worth investing much time to fix if it's not super easy

image

@ivan-aksamentov
Copy link
Member

ivan-aksamentov commented Oct 17, 2024

Yep, there might be a few seconds between new index.json is already copied to S3 and the rest of the files are still being copied plus then their Cloudfront cache invalidation completes.

index.json is not cached currently to avoid being stale (here it functions similarly to how index.html is for web apps)

There is probably a smarter way to do atomic, zero-downtime deployments. One improvement could be to reorder the copies - copy data files first, invalidate cache and then copy index.json when data it points to is in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants