Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a consistent "country" name across USVI samples (both submitted to GenBank and not-yet) #40

Closed
j23414 opened this issue Feb 26, 2024 · 0 comments · Fixed by #41
Closed
Labels
bug Something isn't working

Comments

@j23414
Copy link
Contributor

j23414 commented Feb 26, 2024

Current Behavior

From slack:

the 'country' of those 26 is "Usvi" whereas the 5 samples originating from GenBank (e.g. accession "MW165884") have country of "Virgin Islands"

Can also see it here on the live site:

Expected behavior

That the country names would be consistent for both USVI that has been submitted to GenBank and not-yet-submitted to GenBank.

How to reproduce

Possible solution

From slack:

I think there are two options, either of which is better than the current approach which uses a mixture:

  1. Change genbank to "USVI" during curate. From memory this was what Alli always used and so I think this is the intended country name. (It should be all-caps, but this isn't a dealbreaker.)
  2. Change the spiked-in sequences to "Virgin Islands" to match GenBank. We'll need to add lat/longs for this as it's not in Augur's defaults and thus doesn't show in Auspice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant