Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: show sample time additionally to the currently shown cursor time #123

Open
Apollo3zehn opened this issue Jul 11, 2024 · 4 comments
Open
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers web UI

Comments

@Apollo3zehn
Copy link
Member

grafik

@Apollo3zehn Apollo3zehn added enhancement New feature or request good first issue Good for newcomers web UI labels Jul 11, 2024
@Conundraah Conundraah self-assigned this Aug 6, 2024
@Conundraah
Copy link
Contributor

Don't we get this time stamp when we hover with the mouse over the data point?

@Apollo3zehn
Copy link
Member Author

Not the exact time but I am unsure now how to implement this properly. We could invest time and show a popup with time and value info when the user hovers over the data point, or we could show two time stamps in the bottom part of the chart which could be confusing.

I think the popup would be a better solution but can be quite time-consuming to implement because the popup may behave wrong on the edge of the chart without special handling.

Since this issue is not very important I would postpone it and work on other more urgent issues. What do you think?

@Conundraah
Copy link
Contributor

Now, after another look at the issue I have a more basic question: Why is the cursor time displayed and not the sample time? Isn't the latter more important?

I also have the feeling that implementing a pop up can become quite time consuming and I agree that we can postpone this issue. :-)

@Apollo3zehn
Copy link
Member Author

Apollo3zehn commented Aug 7, 2024

The reason is that the graph is able to show data of different sample rates at the same time. You can see it here in the chart-test page:

https://nexus.iwes.fraunhofer.de/chart-test

Zoom-in a little bit into the data and then you will see that the sample periods are different.

Otherwise, yes, it would make more sense to show the data point time.

So now that I remembered why we show the cursor time, it becomes clear that it is not possible to show the data point time next to the cursor time because different sample periods are possible and so we would need to display one time per sample period.

This means that only the popup solution will work and I still think that this is not so important right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers web UI
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants