Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with MQC not displaying post-ar trimming FastQC results #1075

Merged
merged 10 commits into from
Jun 28, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jun 7, 2024

Closes #1073
Closes #1079

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 requested a review from TCLamnidis June 7, 2024 13:40
Copy link

github-actions bot commented Jun 7, 2024

Markdown linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install markdownlint-cli
  • Fix the markdown errors
    • Automatically: markdownlint . --config .github/markdownlint.yml --fix
    • Manually resolve anything left from markdownlint . --config .github/markdownlint.yml

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

CHANGELOG.md Outdated Show resolved Hide resolved
@jfy133
Copy link
Member Author

jfy133 commented Jun 21, 2024

@TCLamnidis can you do release procedure?

@TCLamnidis
Copy link
Collaborator

@jfy133 happy with the wording of the lanemerge output docs?

Copy link
Member Author

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, extra just to clarify given the original context.

Don't forget to put yourself as the person making the fix

docs/output.md Outdated Show resolved Hide resolved
Co-authored-by: James A. Fellows Yates <[email protected]>
CHANGELOG.md Outdated Show resolved Hide resolved
@TCLamnidis
Copy link
Collaborator

CIs passed. Linting failing due to DSL2 template. Will merge 🙏

@TCLamnidis TCLamnidis merged commit 6505529 into master Jun 28, 2024
5 of 9 checks passed
@TCLamnidis TCLamnidis deleted the patch branch June 28, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants