Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.3.0 #230

Merged
merged 126 commits into from
Feb 26, 2024
Merged

Release 2.3.0 #230

merged 126 commits into from
Feb 26, 2024

Conversation

jonasscheid
Copy link
Contributor

@jonasscheid jonasscheid commented Feb 14, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/epitopeprediction branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

nf-core-bot and others added 30 commits April 28, 2023 14:21
Check sample sheet uses Row Checker class
@christopher-mohr
Copy link
Collaborator

I just removed the "old" CI tests from the required checks

Copy link
Collaborator

@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions so far, I will continue later.

.nf-core.yml Outdated Show resolved Hide resolved
assets/schema_input.json Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
lib/WorkflowEpitopeprediction.groovy Outdated Show resolved Hide resolved
lib/WorkflowEpitopeprediction.groovy Outdated Show resolved Hide resolved
modules/local/epytope_peptide_prediction.nf Show resolved Hide resolved
modules/nf-core/fastqc/environment.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional comments/suggestions

bin/check_requested_models.py Outdated Show resolved Hide resolved
bin/check_requested_models.py Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Copy link

@mapo9 mapo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very nice!
Only some minor stuff

docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Show resolved Hide resolved
nextflow.config Show resolved Hide resolved
nextflow_schema.json Outdated Show resolved Hide resolved
nextflow_schema.json Outdated Show resolved Hide resolved
@christopher-mohr
Copy link
Collaborator

christopher-mohr commented Feb 23, 2024

Let's get another review for this once tests pass because of the most recent template change.

@jonasscheid jonasscheid requested a review from mapo9 February 23, 2024 12:06
Copy link

@mapo9 mapo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

just one minor change to improve readability of a parameter

nextflow_schema.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasscheid jonasscheid merged commit e173620 into master Feb 26, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants